Pandas performance & automated release #144
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| --- | ||
| name: build-package-release | ||
|
|
||
| on: push | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build Python Distribution | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout source | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 2 | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.11" | ||
| - name: Build source and wheel distributions | ||
| run: | | ||
| python -m pip install --upgrade build twine | ||
| python -m build | ||
| twine check --strict dist/* | ||
| - name: Store the distribution packages | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: python-package-distributions | ||
| path: dist/ | ||
|
|
||
| pypi-publish: | ||
| name: Upload release to PyPI | ||
| if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') | ||
| needs: | ||
| - build | ||
| runs-on: ubuntu-latest | ||
| environment: | ||
| name: pypi | ||
| url: https://pypi.org/p/catalystcoop.ferc-xbrl-extractor | ||
| permissions: | ||
| id-token: write | ||
| steps: | ||
| - name: Download all the dists | ||
| uses: actions/download-artifact@v3 | ||
| with: | ||
| name: python-package-distributions | ||
| path: dist/ | ||
| - name: Publish distribution to PyPI | ||
| uses: pypa/gh-action-pypi-publish@release/v1 | ||
|
|
||
| github-publish: | ||
| name: Release package on GitHub | ||
| needs: | ||
| - pypi-publish | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| id-token: write | ||
| steps: | ||
| - name: Download all the dists | ||
| uses: actions/download-artifact@v3 | ||
| with: | ||
| name: python-package-distributions | ||
| path: dist/ | ||
| - name: Sign dist with Sigstore | ||
| uses: sigstore/[email protected] | ||
| with: | ||
| inputs: ./dist/*.tar.gz ./dist/*.whl | ||
| - name: Upload artifact signatures to GitHub Release | ||
| env: | ||
| GITHUB_TOKEN: ${{ github.token }} | ||
| run: >- | ||
| gh release create '${{ github.ref_name }}' ./dist/*.tar.gz ./dist/*.whl | ||
| --generate-notes | ||
| --repo '${{ github.repository }}' | ||
|
|
||
| release-notify: | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - github-publish | ||
| if: ${{ always() }} | ||
| steps: | ||
| - name: Inform the Codemonkeys | ||
| uses: 8398a7/action-slack@v3 | ||
| continue-on-error: true | ||
| with: | ||
| status: custom | ||
| fields: workflow,job,commit,repo,ref,author,took | ||
| custom_payload: | | ||
| { | ||
| username: 'action-slack', | ||
| icon_emoji: ':octocat:', | ||
| attachments: [{ | ||
| color: '${{ needs.github-publish.result }}' === 'success' ? 'good' : '${{ needs.github-publish.result }}' === 'failure' ? 'danger' : 'warning', | ||
| text: `${process.env.AS_REPO}@${process.env.AS_REF}\n ${process.env.AS_WORKFLOW} (${process.env.AS_COMMIT})\n by ${process.env.AS_AUTHOR}\n Status: ${{ needs.github-publish.result }}`, | ||
| }] | ||
| } | ||
| env: | ||
| GITHUB_TOKEN: ${{ github.token }} # required | ||
| SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} # required | ||
| MATRIX_CONTEXT: ${{ toJson(matrix) }} # required |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,9 +84,11 @@ def _dedupe_newer_report_wins(df: pd.DataFrame, primary_key: list[str]) -> pd.Da | |
| old_index = df.index.names | ||
| return ( | ||
| df.reset_index() | ||
| .sort_values("report_date") | ||
| .groupby(unique_cols) | ||
| .last() | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. Perfect! That's the exact intent & also this conveys what's going on way better! |
||
| .drop("report_date", axis="columns") | ||
| .reset_index() | ||
| .set_index(old_index) | ||
| ) | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can
sort_values()before doing the groupby because according to the groupby docs "Groupby preserves the order of rows within each group."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One potentially non-deterministic outcome here is that if there are duplicate values of
report_datewithin a group then which row of data ends up being "last" might not always be the same. Do we think there can ever be multiple filings within a group that have the same date?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
For some reason, I made this issue in the PUDL repo instead: catalyst-cooperative/pudl#2822 but the short of it is "we need to use metadata from
rssfeedto sort them better."