-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dataset configuration code as constructors #659
Refactor dataset configuration code as constructors #659
Conversation
I think this pattern does indeed look much better, and is more standard/consistent with other class constructors in our ecosystem too One small comment about the annotation typing for the return |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage 91.61% 91.62%
=======================================
Files 107 107
Lines 5630 5646 +16
=======================================
+ Hits 5158 5173 +15
- Misses 472 473 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Interesting - automerge did not trigger when a job was manually cancelled (having some kind of intermittent stall problem with mac runners...) even after all conditions passed |
As discussed in #569
#569 (comment)
This should keep code that is related together and simplify code navigation.