feat(ansi): add hsl
and rgb
values
#110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have probably done this in the initial release.
I've chosen to still use
tinycolor2
but I'm wondering if it's better to use the newcolorjs.io
dependency here. It would be nice to move away from tinycolor2 to ensure that we're only using one colour library but I suppose it doesn't really hurt anyone if we decide to keep both.Going forward, we should decide if we want to:
Move away from
tinycolor2
in favour ofcolorjs.io
for all colour transformations. Unfortunately, moving away fromtinycolor2
would mean a slight breaking change in the precision for HSL values so that's something to keep in mind, see example below:OR
tinycolor2
andcolorjs.io
but ensure thatcolorjs.io
is only used for the LCH modifications as that is the only reason I brought it in (tinycolor2
doesn't support LCH modifications - Support for LCH? bgrins/TinyColor#237)