Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add emoji for each flavor #81

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

uncenter
Copy link
Member

Closes #80.

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I like how the PR looks but I also had some other thoughts on whether we should also include more data including the codepoints and the short name? I don't know enough about emoji rendering and how much the other fields matter but figure it could be nice?

Maybe something like:

"emoji": {
	"rendered": "🌻",
	"codepoint": "U+1F33B",
	"cldr_short_name": "sunflower"
}

Maybe I'm wayyy overthinking it but figured I'd comment it anyways, curious what you think
cc: @catppuccin/staff

Ref: https://unicode.org/emoji/charts/emoji-list.html

mod.ts Outdated Show resolved Hide resolved
@uncenter
Copy link
Member Author

Thanks for the PR.

I like how the PR looks but I also had some other thoughts on whether we should also include more data including the codepoints and the short name? I don't know enough about emoji rendering and how much the other fields matter but figure it could be nice?

Maybe something like:

"emoji": {
	"rendered": "🌻",
	"codepoint": "U+1F33B",
	"cldr_short_name": "sunflower"
}

Maybe I'm wayyy overthinking it but figured I'd comment it anyways, curious what you think cc: @catppuccin/staff

Ref: unicode.org/emoji/charts/emoji-list.html

Hmm IMO this isn't needed. As per your original issue, {{ flavor.emoji }} is nicer/easier to use than {{ flavor.emoji.rendered }}. Also I don't see an immediate usecase for the additional properties, and if a usecase does come up it is pretty easy to use a library or built in functions (e.g. codePointAt() in JS) to find that information out.

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should run deno task generate as part of the PR since the CI only runs deno task build, unless you already have 😄

@uncenter
Copy link
Member Author

uncenter commented May 13, 2024

I believe you should run deno task generate as part of the PR since the CI only runs deno task build, unless you already have 😄

I did but iirc there weren't any changes?

EDIT: Yeah no changes after running both commands.

@uncenter uncenter requested a review from sgoudham May 14, 2024 12:20
@sgoudham sgoudham merged commit 0abf33d into catppuccin:main May 17, 2024
1 check passed
@sgoudham sgoudham mentioned this pull request May 17, 2024
1 task
@uncenter uncenter deleted the feat/emojis branch May 17, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include flavour emojis as part of the palette.json
2 participants