feat: add support for apple color list / .clr files #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncenter
commented
Jul 21, 2024
uncenter
commented
Jul 21, 2024
sgoudham
reviewed
Sep 5, 2024
sgoudham
requested changes
Sep 8, 2024
There was a problem hiding this comment.
While fixing the CI errors locally, I realised that this PR breaks the deno task build:palettes command unless you are on macOS.
I think it would be better, while more effort, to extract out the swift compilation into another step that isn't ran as part of the build:palettes command by default since it currently prevents the command from succeeding.
Might even be as simple as checking if an environment variable COMPILE_APPLE_COLOR_LIST is set to 1 or something.
uncenter
commented
Sep 8, 2024
Co-authored-by: uncenter <[email protected]>
sgoudham
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings https://github.com/uncenter/ctp-clr to this repository. I would like to add instructions for how exactly to use these files but it doesn't look like we have any existing instructions for the other palette files / apps.