-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multiphase material #675
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #675 +/- ##
===========================================
+ Coverage 96.62% 96.66% +0.03%
===========================================
Files 123 122 -1
Lines 25318 25352 +34
===========================================
+ Hits 24463 24504 +41
+ Misses 855 848 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should set the materials_ size in the particle constructor and not allow to add more than 1 material, if the particle type doesn't support it.
@kks32 I added another enhancement in the |
Describe the PR
This PR added an enhancement to deal with multiphase material initialization from file, which is essential for
two_phase_particle
either in explicit or implicit solver, or later onthree_phase_particle
. The current proposal will work ok with MPI transfer or read from hdf5 for the single-phaseparticle
as I am using a default phase argument to be solid. However, hdf5 initialization and MPI transfer process for two-phase is not yet implemented. This should be integrated after we find an approach to deal with multiphase hdf5 output (@kks32 is investigating that).Related Issues/PRs
#633
Additional context
I also added a small modification of pressure smoothing. @tianchiTJ @WeijianLiang Can we store
pore_pressure
as a state variable in the fluid material? By doing so, we can use the same smoothing routine as we use in the single-phasepressure
.