Much more robust API (may help a lot of people) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2013 20:04
0) Returns proper HTML response codes 1) Much faster! (because it returns proper response codes browser doesn't wait!) 2) Can't crash the app by sending bad data (checks what you send it) 3) Makes sure the browser won't cache the data (problem solved) 4) If it can't update or delete an item you now will be notified properly
Christophe: LOVE your tutorials! I have learned quite a bit! I wanted to give back by improving your wines api a bit - 0) Returns proper HTML response codes 1) Much faster! (because it returns proper response codes browser doesn't wait...) 2) Can't crash the app by sending bad data (checks what you send it) 3) Makes sure the browser won't cache the data (problem solved) 4) If it can't update or delete an item you now will be notified properly 5) res.send changed to res.json
| // if (req.session.userAuthenticated) { | ||
|
|
||
| // We don't want the browser to cache the results | ||
| res.header('Cache-Control', 'no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0'); |
There was a problem hiding this comment.
I'm just a watcher on this repo but wanted to comment that it's awesome that you've added no caching ✨
There was a problem hiding this comment.
Thanks Ryan!
On Thu, Jan 24, 2013 at 8:45 PM, Ryan Regalado [email protected]:
In routes/wines.js:
exports.findById = function(req, res) {
+
- // At some point we may want to lock this api down!
- // If this is on the Internet someone could easily
- // steal, modify or delete your data! Need something like
- // this on our api (assuming we have people authenticate):
- // if (req.session.userAuthenticated) {
- // We don't want the browser to cache the results
- res.header('Cache-Control', 'no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0');
I'm just a watcher on this repo but wanted to comment that it's awesome
that you've added no caching [image: ✨]—
Reply to this email directly or view it on GitHubhttps://github.com//pull/6/files#r2770226.
- Dan Stroot
|
Christophe - sorry I put this in the master branch - kind of new to all this. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Christophe: LOVE your tutorials! I have learned quite a bit! I wanted to give back by improving your wines api a bit -
doesn't wait...)
properly