Bump dependency versions #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to cdevents#38 Signed-off-by: Andres Almiray <[email protected]>
afrittoli
reviewed
Feb 28, 2024
| <packageurl.version>1.4.1</packageurl.version> | ||
| <commons-lang3.version>3.14.0</commons-lang3.version> |
afrittoli
reviewed
Feb 28, 2024
| @@ -46,7 +46,7 @@ | |||
| <dependency> | |||
| <groupId>org.apache.commons</groupId> | |||
| <artifactId>commons-lang3</artifactId> | |||
| <version>3.12.0</version> | |||
| <version>${commons-lang3.version}</version> | |||
There was a problem hiding this comment.
Does this mean that the version used by the generator and the SDK must be the same now?
I don't mind, we can still split it future if needed, right?
There was a problem hiding this comment.
They don't have to match per se but it makes sense to keep it this way if there were to be any CVEs in one version fixed in another.
afrittoli
approved these changes
Feb 28, 2024
rjalander
approved these changes
Feb 28, 2024
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #38