Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add version increment/control functionality #61

Merged
merged 1 commit into from
Jul 21, 2023
Merged

feat: add version increment/control functionality #61

merged 1 commit into from
Jul 21, 2023

Conversation

mentlak0
Copy link
Collaborator

@mentlak0 mentlak0 commented Jul 20, 2023 •
edited
Loading

  • use jx-release-version to get next chart version and then insert the change
  • add actions to check that the Chart.yaml file has been updated
  • add conditional logic to only publish chart if changes have been made
  • amend affinities with default values for webhook and controller dpeloy e.g notIn windows.
  • update README to inform that jx-release-version needs to be used and how to update chart version

@mentlak0 mentlak0 marked this pull request as ready for review July 20, 2023 14:00
tomhobson
tomhobson requested changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@tomhobson tomhobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see where this exits with a bad status code if the version hasn't been incremented

@mentlak0 mentlak0 requested a review from tomhobson July 21, 2023 09:43
@tomhobson tomhobson merged commit fc2ad8f into cdfoundation:main Jul 21, 2023
1 check passed
@tomhobson tomhobson deleted the incrememnt-chart-version branch July 21, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhobson tomhobson tomhobson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mentlak0 @tomhobson