Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder upload and security middlewares #866

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Reorder upload and security middlewares #866

merged 1 commit into from
Nov 12, 2023

Conversation

mdmower
Copy link
Contributor

@mdmower mdmower commented Oct 13, 2023

  • Move multipart middleware after security middleware so that security handlers can abort request pipeline before uploads are processed.

Fixes #865

@mdmower
Reorder upload and security middlewares
d0719c5 
- Move multipart middleware after security middleware so that security
  handlers can abort request pipeline before uploads are processed.

Fixes cdimascio#865
@mdmower
Copy link
Contributor Author

mdmower commented Oct 13, 2023

Thanks @cdimascio, this is ready for review when you have time.

@mdmower-csnw mdmower-csnw mentioned this pull request Oct 18, 2023
Closed
@cdimascio cdimascio merged commit 95543d6 into cdimascio:master Nov 12, 2023
5 checks passed
@rish2497 rish2497 mentioned this pull request May 24, 2024
Open
@davesag davesag mentioned this pull request Jun 23, 2024
Open
This was referenced Jun 24, 2024
Closed
Merged
@davesag davesag mentioned this pull request Jul 13, 2024
Open
@davesag davesag mentioned this pull request Aug 2, 2024
Open
@cdimascio cdimascio mentioned this pull request Aug 5, 2024
Merged
This was referenced Aug 26, 2024
Closed
Merged
Merged
@rish2497 rish2497 mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 15, 2024
Closed
Closed
@cdimascio cdimascio mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdimascio cdimascio cdimascio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multipartMiddleware preceeds securityMiddleware so files begin uploading before security check
2 participants
@mdmower @cdimascio