Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #887 allow multiple params with wildcard #898

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: #887 allow multiple params with wildcard #898

merged 2 commits into from
Feb 2, 2024

Conversation

Mitchell3514
Copy link
Contributor

  • add test for paths with multiple params including a wildcard param
  • update the toExpressParams wildcard regex

Fixes: #887

Mitchell3514 and others added 2 commits January 31, 2024 17:42
@Mitchell3514
Add multiple path parameters with wildcard tests
327646e
@guillerecalde @Mitchell3514
Change regex to support multiple params when including file path para…
9fb9a3a 
…ms (#1)

* Change regex to support multiple params when including URI path param
* Update regex, remove unnecessary bracket
@cdimascio cdimascio merged commit 2d33d0a into cdimascio:master Feb 2, 2024
5 checks passed
@cdimascio
Copy link
Owner

Thanks!

@guillerecalde
Copy link
Contributor

Hey @cdimascio, any chance you have an ETA for when this fix will be released?

cdimascio
cdimascio reviewed Feb 10, 2024
View reviewed changes
Copy link
Owner

@cdimascio cdimascio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v5.1.4+ contains the fix

@rish2497 rish2497 mentioned this pull request May 24, 2024
Open
@davesag davesag mentioned this pull request Jun 23, 2024
Open
This was referenced Jun 24, 2024
Closed
Merged
@davesag davesag mentioned this pull request Jul 13, 2024
Open
@davesag davesag mentioned this pull request Aug 2, 2024
Open
@cdimascio cdimascio mentioned this pull request Aug 5, 2024
Merged
This was referenced Aug 26, 2024
Closed
Merged
Merged
This was referenced Sep 13, 2024
Open
Open
This was referenced Sep 15, 2024
Closed
Closed
@rish2497 rish2497 mentioned this pull request Sep 22, 2024
Open
@cdimascio cdimascio mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdimascio cdimascio cdimascio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple path params break support for URI path param
3 participants
@Mitchell3514 @cdimascio @guillerecalde