-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async operation handler resolver #921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Let users define operationHandlers.resolver as a synchronous or asynchronous function that returns a request handler - Make installOperationHandlers and asynchronous function that awaits a resolver promise (automatically wraps resolver with promise if needed) - Update operation handlers middleware to handle an async installOperationHandlers.
cdimascio
approved these changes
Jun 2, 2024
This was referenced Jun 24, 2024
This was referenced Aug 26, 2024
mdmower-csnw
added a commit
to CSNW/express-openapi-validator
that referenced
this pull request
Aug 30, 2024
In cdimascio#921, a stronger type applied to OperationHandlerOptions['resolver'] so that end users would have an idea of what the parameters are for their custom resolvers. It went too far in stipulating a return type. Set the return type to unknown and let users decide how much type safety they need in their resolver. Fixes cdimascio#952
cdimascio
pushed a commit
that referenced
this pull request
Aug 31, 2024
In #921, a stronger type applied to OperationHandlerOptions['resolver'] so that end users would have an idea of what the parameters are for their custom resolvers. It went too far in stipulating a return type. Set the return type to unknown and let users decide how much type safety they need in their resolver. Fixes #952
This was referenced Sep 13, 2024
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operationHandlers.resolver
as a synchronous or asynchronous function that returns a request handlerinstallOperationHandlers
an asynchronous function that awaits a resolver promise (automatically wraps resolver with promise if needed)installOperationHandlers
.This is similar to the approach mentioned in #660 but makes it possible to use
await import()
in the resolver so that a new request handler doesn't have to be created as a wrapper. Then, the default resolver requires very little modification. I was able to replaceexpress-openapi-validator/src/resolvers.ts
Lines 33 to 38 in 4e8bc84
and otherwise use the default resolver as-is.