-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAW MMAL Buffer callback #51
Open
kaomoneus
wants to merge
15
commits into
cedricve:master
Choose a base branch
from
kaomoneus:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… been moved into separate 'process_video_buffer'.
public_hdrs_base and srcs_base initialization has been multilined. Now if you will add new values to these variables, you will see more readable changesets with diff tools.
…eed to use buffers asyncronously on client side. So this commit adds some amount of buffers to recommended buffers for camera component.
…header holder, with custom deleter which releases buffer.
…t. Target texture seems to be filled by zeroes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola! This pull request is rather an idea, and I just ask you to consider it, and if you like it, then I work on making changeset sequence of better quality.
The main goal is to prevent extra copy operation during "grab".
The main idea is to provide user with callback, and comfortable way to release buffer back into pool when we're done with it. So in short when we got a
video_buffer_callback
, our steps as follows:For that purpose
RaspiCamRawBuffer
has been introduced. Which is a wrapper for MMAL buffer. It is passed intoRawBufferCallback
, and for a while it is out of main frame grabbing pipeline.It counts references, and once user finished its processing, reference counters will become zero, and buffer is released back into pool.
I have tested this approach in my own application and it allows to achieve much better FPS on high resolution frames.
How to use it
Setup
Callback
P.S.: this PR also contains another improvements, I'll probably clean out, since it is subject of another PRs. Namely: