Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt for logging lock internal changes in Python3.13 #404

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

musicinmybrain
Copy link
Contributor

Fixes #403.

A brief discussion of the approach is in #403 (comment).

Tested with:

$ PYTHONPATH="${PWD}" python3.12 -c 'from billiard.util import get_logger; print(get_logger())'
<Logger multiprocessing (WARNING)>
$ PYTHONPATH="${PWD}" python3.13 -c 'from billiard.util import get_logger; print(get_logger())'
<Logger multiprocessing (WARNING)>

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your logic makes perfect sense to me.
PR Changes look clean and on-point.

Approved by me - thank you!

@auvipy auvipy merged commit 81cc942 into celery:main Jun 15, 2024
7 of 8 checks passed
@musicinmybrain
Copy link
Contributor Author

You’re welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.13: billiard.util.get_logger() is broken
3 participants