-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nonce): Update core_access.go adjust network nonce #3980
base: main
Are you sure you want to change the base?
feat(nonce): Update core_access.go adjust network nonce #3980
Conversation
Shouldn't this be the responsibility of the Signer? We could add this as a hotfix if its a pressing issue, but the node is not responsible for nounce management and error recovery of tx sending. The Signer component is. cc @cmwaters |
Where does the Signer component live in the architecture diagram? Let's imagine https://github.com/celestiaorg/nitro-das-celestia and Nitro deployment. Cc @Ferret-san |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3980 +/- ##
==========================================
+ Coverage 44.83% 45.30% +0.46%
==========================================
Files 265 308 +43
Lines 14620 22002 +7382
==========================================
+ Hits 6555 9968 +3413
- Misses 7313 10953 +3640
- Partials 752 1081 +329 ☔ View full report in Codecov by Sentry. |
Continuation of the discussion here: celestiaorg/celestia-app#4067
This PR adds the ability for self-adjusting flow when clients submit blobs and the message returned yells that the nonce is out of sync.
Caldera has been using this in mocha-4 and celestia network for months now and it would be beneficial for both to close the gaps on changes we've implemented.