Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nonce): Update core_access.go adjust network nonce #3980

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

InoMurko
Copy link

@InoMurko InoMurko commented Dec 4, 2024

Continuation of the discussion here: celestiaorg/celestia-app#4067

This PR adds the ability for self-adjusting flow when clients submit blobs and the message returned yells that the nonce is out of sync.

Caldera has been using this in mocha-4 and celestia network for months now and it would be beneficial for both to close the gaps on changes we've implemented.

@github-actions github-actions bot added the external Issues created by non node team members label Dec 4, 2024
@Wondertan
Copy link
Member

Shouldn't this be the responsibility of the Signer? We could add this as a hotfix if its a pressing issue, but the node is not responsible for nounce management and error recovery of tx sending. The Signer component is.

cc @cmwaters

@InoMurko
Copy link
Author

InoMurko commented Dec 4, 2024

Shouldn't this be the responsibility of the Signer? We could add this as a hotfix if its a pressing issue, but the node is not responsible for nounce management and error recovery of tx sending. The Signer component is.

cc @cmwaters

Where does the Signer component live in the architecture diagram? Let's imagine https://github.com/celestiaorg/nitro-das-celestia and Nitro deployment. Cc @Ferret-san

@Wondertan
Copy link
Member

@InoMurko, the Signer is a component sitting on the app side. It has smarts around nounce and error handling during tx submission, and it seems to have a bug.

@renaynay renaynay self-assigned this Dec 4, 2024
@renaynay renaynay added area:state Related to fetching state and state execution kind:feat Attached to feature PRs area:api Related to celestia-node API labels Dec 4, 2024
@Ferret-san
Copy link

Where does the Signer component live in the architecture diagram? Let's imagine https://github.com/celestiaorg/nitro-das-celestia and Nitro deployment. Cc @Ferret-san

nitro-das-celestia is just a proxy between the Nitro codebase and a celestia node, so it will use whatever key you setup the celestia node to use.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 45.30%. Comparing base (2469e7a) to head (5c14084).
Report is 403 commits behind head on main.

Files with missing lines Patch % Lines
state/core_access.go 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3980      +/-   ##
==========================================
+ Coverage   44.83%   45.30%   +0.46%     
==========================================
  Files         265      308      +43     
  Lines       14620    22002    +7382     
==========================================
+ Hits         6555     9968    +3413     
- Misses       7313    10953    +3640     
- Partials      752     1081     +329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API area:state Related to fetching state and state execution external Issues created by non node team members kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants