Skip to content

Commit

Permalink
code pointers
Browse files Browse the repository at this point in the history
  • Loading branch information
alecps committed Jul 30, 2024
1 parent 78870df commit e8faeeb
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cmd/geth/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ func prepare(ctx *cli.Context) {
// geth is the main entry point into the system if no special subcommand is ran.
// It creates a default node based on the command line arguments and runs it in
// blocking mode, waiting for it to be shut down.
func geth(ctx *cli.Context) error {
func geth(ctx *cli.Context) error { // TODO(Alec) code pointer
if args := ctx.Args(); len(args) > 0 {
return fmt.Errorf("invalid command: %q", args[0])
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/utils/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func Fatalf(format string, args ...interface{}) {
os.Exit(1)
}

func StartNode(ctx *cli.Context, stack *node.Node) {
func StartNode(ctx *cli.Context, stack *node.Node) { // TODO(Alec) code pointer
if err := stack.Start(); err != nil {
Fatalf("Error starting protocol stack: %v", err)
}
Expand Down
2 changes: 1 addition & 1 deletion consensus/istanbul/backend/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -1058,7 +1058,7 @@ func (sb *Backend) SetStartValidatingBlock(blockNumber *big.Int) error {
}

// SetStopValidatingBlock sets the block that the validator will stop just before (exclusive range)
func (sb *Backend) SetStopValidatingBlock(blockNumber *big.Int) error {
func (sb *Backend) SetStopValidatingBlock(blockNumber *big.Int) error { // TODO(Alec) code pointer
if sb.replicaState == nil {
return errNotAValidator
}
Expand Down
2 changes: 1 addition & 1 deletion consensus/istanbul/core/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func (c *core) Start() error {
}

// Stop implements core.Engine.Stop
func (c *core) Stop() error {
func (c *core) Stop() error { // TODO(Alec) code pointer
c.stopAllTimers()
c.unsubscribeEvents()

Expand Down
2 changes: 1 addition & 1 deletion core/blockchain.go
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ func (bc *BlockChain) ContractCodeWithPrefix(hash common.Hash) ([]byte, error) {

// Stop stops the blockchain service. If any imports are currently in progress
// it will abort them using the procInterrupt.
func (bc *BlockChain) Stop() {
func (bc *BlockChain) Stop() { // TODO(Alec) code pointer
if !atomic.CompareAndSwapInt32(&bc.running, 0, 1) {
return
}
Expand Down
2 changes: 1 addition & 1 deletion eth/backend.go
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ func (s *Ethereum) Start() error {

// Stop implements node.Lifecycle, terminating all internal goroutines used by the
// Ethereum protocol.
func (s *Ethereum) Stop() error {
func (s *Ethereum) Stop() error { // TODO(Alec) code pointer
// Stop all the peer-related stuff first.
s.stopAnnounce()
s.ethDialCandidates.Close()
Expand Down
2 changes: 1 addition & 1 deletion node/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func (n *Node) Start() error {

// Close stops the Node and releases resources acquired in
// Node constructor New.
func (n *Node) Close() error {
func (n *Node) Close() error { // TODO(Alec) code pointer
n.startStopLock.Lock()
defer n.startStopLock.Unlock()

Expand Down

0 comments on commit e8faeeb

Please sign in to comment.