-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipping flaky tests #1848
Skipping flaky tests #1848
Conversation
Coverage from tests in coverage: 51.7% of statements across all listed packagescoverage: 65.6% of statements in consensus/istanbul coverage: 41.8% of statements in consensus/istanbul/announce coverage: 55.4% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 71.7% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 75.3% of statements in consensus/istanbul/uptime coverage: 100.0% of statements in consensus/istanbul/uptime/store coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 5dd1388110 |
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
- Coverage 54.28% 54.18% -0.10%
==========================================
Files 671 673 +2
Lines 88964 88989 +25
==========================================
- Hits 48296 48222 -74
- Misses 37012 37129 +117
+ Partials 3656 3638 -18
Continue to review full report at Codecov.
|
@hbandura Looks good, can you make the associated tickets before we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR comments/skips tests, builds and benchmarks that are known to be flaky.
Unit tests:
Benchmarks:
Circleci builds:
While creating this PR, the istanbul-e2e-coverage failed once, then worked when it was re-run. I'm not skipping this one right now since I'd like to test it a bit more. Most likely it is because the parent commit has flaky tests, which are run for coverage report.
codecov/project is failing because we are removing a few tests. It is expected.