Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to the roundstate_db #2040

Closed
wants to merge 3 commits into from
Closed

Conversation

hbandura
Copy link
Contributor

@hbandura hbandura commented Mar 9, 2023

Add metrics to measure db save time, rlp encoding time, and rlp encoding size, to roundstate_db.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 8e66bca

coverage: 50.2% of statements across all listed packages
coverage:  60.2% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.8% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  63.9% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

5854 passed, 1 failed, 45 skipped

Test failures:
  TestEthersJSCompatibilityDisableAfterGingerbread: e2e_test
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000 denominator = 1000000000000000000000000
Checking gas price minimum. cusdValue = 100000000
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000 denominator = 1000000000000000000000000
Checking gas price minimum. cusdValue = 100000000
e2e_test.go:742:
e2e_test.go:744:
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% 🎉

Comparison is base (0404e7a) 55.15% compared to head (6a4b726) 55.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2040      +/-   ##
==========================================
+ Coverage   55.15%   55.28%   +0.12%     
==========================================
  Files         676      676              
  Lines      114015   114027      +12     
==========================================
+ Hits        62887    63037     +150     
+ Misses      47248    47133     -115     
+ Partials     3880     3857      -23     
Files Changed Coverage Δ
consensus/istanbul/core/roundstate_db.go 60.26% <100.00%> (+1.61%) ⬆️

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbandura hbandura force-pushed the hbandura/roundstate_metrics branch from 98859ca to d2ff7ef Compare March 15, 2023 17:18
Copy link
Contributor

@palango palango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@palango
Copy link
Contributor

palango commented Apr 28, 2023

@hbandura Should we merge this?

@carterqw2
Copy link
Contributor

Implemented as part of #2184

@carterqw2 carterqw2 closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants