-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics to the roundstate_db #2040
Conversation
Coverage from tests in coverage: 50.2% of statements across all listed packagescoverage: 60.2% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 63.9% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2040 +/- ##
==========================================
+ Coverage 55.15% 55.28% +0.12%
==========================================
Files 676 676
Lines 114015 114027 +12
==========================================
+ Hits 62887 63037 +150
+ Misses 47248 47133 -115
+ Partials 3880 3857 -23
☔ View full report in Codecov by Sentry. |
98859ca
to
d2ff7ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@hbandura Should we merge this? |
Implemented as part of #2184 |
Add metrics to measure db save time, rlp encoding time, and rlp encoding size, to roundstate_db.