Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge native tracer #2137

Merged
merged 21 commits into from
Jun 26, 2023
Merged

Merge native tracer #2137

merged 21 commits into from
Jun 26, 2023

Conversation

palango
Copy link
Contributor

@palango palango commented Jun 22, 2023

Description

Continuation of #1978, but pushed int his repo so that all CI jobs work.

holiman and others added 20 commits April 19, 2023 18:14
This PR changes long-running chain tracing, so that it at some points releases the memory trie db, and switch over to a fresh disk-backed trie.

Signed-off-by: Delweng <[email protected]>
* eth/tracers: add basic native loader

* eth/tracers: add GetResult to tracer interface

* eth/tracers: add native call tracer

* eth/tracers: fix call tracer json result

* eth/tracers: minor fix

* eth/tracers: fix

* eth/tracers: fix benchTracer

* eth/tracers: test native call tracer

* eth/tracers: fix

* eth/tracers: rm extra make

Co-authored-by: Martin Holst Swende <[email protected]>

* eth/tracers: rm extra make

* eth/tracers: make callFrame private

* eth/tracers: clean-up and comments

* eth/tracers: add license

* eth/tracers: rework the model a bit

* eth/tracers: move tracecall tests to subpackage

* cmd/geth: load native tracers

* eth/tracers: minor fix

* eth/tracers: impl stop

* eth/tracers: add native noop tracer

* renamings

Co-authored-by: Martin Holst Swende <[email protected]>

* eth/tracers: more renamings

* eth/tracers: make jstracer non-exported, avoid cast

* eth/tracers, core/vm: rename vm.Tracer to vm.EVMLogger for clarity

* eth/tracers: minor comment fix

* eth/tracers/testing: lint nitpicks

* core,eth: cancel evm on nativecalltracer stop

* Revert "core,eth: cancel evm on nativecalltracer stop"

This reverts commit 01bb908790a369c1bb9d3937df9325c6857bf855.

* eth/tracers: linter nits

* eth/tracers: fix output on err

Co-authored-by: Martin Holst Swende <[email protected]>
Signed-off-by: Delweng <[email protected]>
* eth/tracers: restructure tracer package

* core/vm/runtime: load js tracers

* eth/tracers: mv bigint js code to own file

* eth/tracers: add method docs for native tracers

* eth/tracers: minor doc fix

* core,eth: cancel evm on nativecalltracer stop

* core/vm: fix failing test

Co-authored-by: Sina Mahmoodi <[email protected]>
Signed-off-by: Delweng <[email protected]>
Make linter happy
@palango palango mentioned this pull request Jun 22, 2023
@palango palango changed the title Feature/go native trace Merge native tracer Jun 22, 2023
@github-actions
Copy link

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 4dcc794

coverage: 47.2% of statements across all listed packages
coverage:  57.9% of statements in consensus/istanbul
coverage:  37.9% of statements in consensus/istanbul/announce
coverage:  54.3% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  58.1% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

5841 passed, 45 skipped

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 66.55% and project coverage change: +0.95 🎉

Comparison is base (71bdbcf) 54.30% compared to head (879d1ca) 55.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
+ Coverage   54.30%   55.25%   +0.95%     
==========================================
  Files         692      675      -17     
  Lines      115642   113730    -1912     
==========================================
+ Hits        62795    62844      +49     
+ Misses      49014    47031    -1983     
- Partials     3833     3855      +22     
Impacted Files Coverage Δ
cmd/devp2p/internal/ethtest/transaction.go 0.00% <0.00%> (ø)
cmd/evm/runner.go 0.00% <0.00%> (ø)
cmd/evm/staterunner.go 0.00% <0.00%> (ø)
cmd/geth/chaincmd.go 0.00% <0.00%> (ø)
cmd/geth/config.go 0.00% <0.00%> (ø)
cmd/geth/main.go 21.39% <ø> (+0.91%) ⬆️
cmd/geth/usage.go 10.90% <ø> (ø)
cmd/utils/flags.go 2.56% <0.00%> (ø)
consensus/istanbul/utils.go 47.10% <ø> (+1.13%) ⬆️
contracts/currency/currency.go 55.00% <ø> (ø)
... and 62 more

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palango palango enabled auto-merge (squash) June 26, 2023 09:57
@palango palango disabled auto-merge June 26, 2023 09:57
@palango palango merged commit 4aa53a0 into master Jun 26, 2023
@palango palango deleted the feature/go-native-trace branch June 26, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants