Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cip-56] Remove freezable check on epoch rewards #2164

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

gastonponti
Copy link
Contributor

Description

Implementation of the CIP-56 (https://github.com/celo-org/celo-proposals/blob/master/CIPs/cip-0056.md)

Tested

Run tests

Backwards compatibility

Part of the Gingerbread Hard Fork

@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit f1ecb60

coverage: 49.7% of statements across all listed packages
coverage:  63.2% of statements in consensus/istanbul
coverage:  43.1% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  60.9% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

github-actions bot commented Jul 25, 2023

5856 passed, 45 skipped

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10% 🎉

Comparison is base (4a1e3fc) 55.16% compared to head (04d481e) 55.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2164      +/-   ##
==========================================
+ Coverage   55.16%   55.27%   +0.10%     
==========================================
  Files         676      676              
  Lines      113990   113991       +1     
==========================================
+ Hits        62880    63005     +125     
+ Misses      47229    47124     -105     
+ Partials     3881     3862      -19     
Files Changed Coverage Δ
consensus/istanbul/backend/pos.go 5.74% <0.00%> (-1.77%) ⬇️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gastonponti gastonponti merged commit f1ecb60 into master Jul 25, 2023
27 checks passed
@gastonponti gastonponti deleted the gastonponti/cip56-implementation branch July 25, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants