Fix eth_getBlockReceipts #2295
Merged
Fix eth_getBlockReceipts #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the api method to take into account the celo block receipt.
|
Coverage from tests in coverage: 50.6% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 41.8% of statements in consensus/istanbul/announce coverage: 55.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 64.9% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
palango
approved these changes
Apr 10, 2024
ezdac
pushed a commit
that referenced
this pull request
Apr 18, 2024
Updated the api method to take into account the celo block receipt. There was previous confusion around whether eth_getBlockReceipts was working or not, as it had worked for some people but not others. This confusion was caused because block receipts are only added when logs have been generated by system calls. Before gingerbread, we would update the gas price minimum on every block and hence create a log for the update, but post gingerbread the only updates that are happening are for epoch blocks. Co-authored-by: Paul Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the api method to take into account the celo block receipt.
There was previous confusion around whether this was working or not, as it had worked for some people but not others.
This confusion was caused because block receipts are only added when logs have been generated by system calls. Before gingerbread, we would update the gas price minimum on every block and hence create a log for the update, but post gingerbread the only updates that are happening are for epoch blocks.
Tested
Manually tested using cast
Related issues