cip66 fixes #2310
Merged
cip66 fixes #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field was not being copied by the copy method.
|
Coverage from tests in coverage: 49.1% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 41.4% of statements in consensus/istanbul/announce coverage: 54.6% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 61.2% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
chuwt
added a commit
to chuwt/celo-blockchain
that referenced
this pull request
Jun 28, 2024
* cip66 fixes (celo-org#2310) * Fix rlp serailisation of cip66 tx to match cip definition https://github.com/celo-org/celo-proposals/blob/master/CIPs/cip-0066.md * Ensure cip66 tx MaxFeeInFeeCurrency is copied The field was not being copied by the copy method. * new tracer * fix new tracer * fix depth * fix top contracts --------- Co-authored-by: piersy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two issues with the current cip66 implementation, firstly
FeeCurrencywas in the wrong position in the struct and secondly thecopymethod was not copyingMaxFeeInFeeCurrencyTested
Manually: Serialized a transaction and inspected it with rlpdump