Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ws and ethers in /e2e_test/ethersjs-api-check #2316

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 16, 2024

Bumps ws to 8.17.1 and updates ancestor dependency ethers. These dependencies need to be updated together.

Updates ws from 8.5.0 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Updates ethers from 6.6.0 to 6.13.1

Release notes

Sourced from ethers's releases.

ethers/v6.13.1 (2024-06-18 02:37)

  • Update ws package to address possible DoS vulnerability (a4b1d1f).

ethers/v6.13.0 (2024-06-04 01:38)

  • Added Options for BrowserProvider (#4707; 33bb0bf).
  • Fix Result deep toObject when a parent is an Array (#4681; d8cb849).
  • Added consistent timeout and cancel behaviour to FetchRequest (#4122; a12a739).

ethers/v6.12.2 (2024-05-30 17:24)

  • Copy EIP-4844 properties during estimateGas and call (#4728; cebe5ee).
  • Use non-capturing regex for data to prevent memory exhaustion for long strings (#4741; 5463aa0).
  • Added Base endpointsto EtherscanProvider (#4729; 7e1dc95).

ethers/v6.12.1 (2024-04-30 23:23)

  • Prevent bad Interface clone when using two different versions of v6 (#4689; 4d2d90f).
  • Fixed typo in error message for invalid quorum weight (#4149; 45b9b9c).
  • Added matic-amoy to EtherescanProvider (#4711; 5c8d17a).
  • Fix JsonRpcProvider ignoring pollingInterval in options (#4644; 7b7be0d).

ethers/v6.12.0 (2024-04-17 02:09)

  • Added Linea Sepolia network and Infura endpoint (#4655; b4aaab8).
  • Do not send unsubscribe messages to destroyed Providers (#4678; c45935e).
  • Get definitive network from InfuraProvider when using InfuraWebSocketProvider (38e32d8).
  • Better error messages for transaction field mismatch (#4659; 9230aa0).
  • Added prevRandao to block (#3372; ec6a754).
  • Added Polygon Amoy testnet (#4645; 1717abb).
  • Added Chainstack provider (#2741; 014004d).
  • Added deep convertion to Result for toObject and toArray (#4681; 03bfe2a).
  • Added EIP-4844 broadcast support (92bad88).
  • Fix ignored throttle parameters (#4663; 12772e9).

ethers/v6.12.0-beta.1 (2024-03-27 14:47)

  • Added EIP-4844 broadcast support.
  • Fix ignored throttle parameters (#4663; 12772e9).

ethers/v6.11.1 (2024-02-14 13:47)

  • Throw an error when attempting to derive from a master path from a non-master node (#4551; 556fdd9).
  • Allow ENS wildcards with labels up to 255 bytes wide; discussed with ENS and deemed safe (#4543; 7f14bde).
  • Enforce string is passed to toUtf8Bytes (#4583; f45bb87).
  • Fix transaction.index not being populated on some backends (#4591; 7f0e140).

ethers/v6.11.0 (2024-02-08 22:02)

  • Allow transaction encoding for inferred type transactions (f02211d).
  • Added EIP-4788, receipts root and state root fields to Block (#4570; c5f126f).
  • Added EIP-4844 fields to Provider classes and formatter (#4570; 7b4f2c1).
  • Assert BrowserProvider receives an EIP-1193 provider to fail early when passing undefined ethereum object (b69f43b).
  • Add timeout to ContractTransactionResponse wait (#4497; 095de51).
  • Allow override keyword in human-readable ABI and improve error messages (#4514, #4548; be5ec2d).
  • Expand Contract sub-class to accept BaseContract super-class constructor arguments (#4538; 98496bc).
  • Allow network for default provider to be null to select mainnet (#4501; b6bf7ab).

... (truncated)

Changelog

Sourced from ethers's changelog.

ethers/v6.13.1 (2024-06-18 02:09)

  • Update ws package to address possible DoS vulnerability (a4b1d1f).

ethers/v6.13.0 (2024-06-04 01:01)

  • Added Options for BrowserProvider (#4707; 33bb0bf).
  • Fix Result deep toObject when a parent is an Array (#4681; d8cb849).
  • Added consistent timeout and cancel behaviour to FetchRequest (#4122; a12a739).

ethers/v6.12.2 (2024-05-30 17:24)

  • Copy EIP-4844 properties during estimateGas and call (#4728; cebe5ee).
  • Use non-capturing regex for data to prevent memory exhaustion for long strings (#4741; 5463aa0).
  • Added Base endpointsto EtherscanProvider (#4729; 7e1dc95).

ethers/v6.12.1 (2024-04-30 22:46)

  • Prevent bad Interface clone when using two different versions of v6 (#4689; 4d2d90f).
  • Fixed typo in error message for invalid quorum weight (#4149; 45b9b9c).
  • Added matic-amoy to EtherescanProvider (#4711; 5c8d17a).
  • Fix JsonRpcProvider ignoring pollingInterval in options (#4644; 7b7be0d).

ethers/v6.12.0 (2024-04-17 01:09)

  • Added Linea Sepolia network and Infura endpoint (#4655; b4aaab8).
  • Do not send unsubscribe messages to destroyed Providers (#4678; c45935e).
  • Get definitive network from InfuraProvider when using InfuraWebSocketProvider (38e32d8).
  • Better error messages for transaction field mismatch (#4659; 9230aa0).
  • Added prevRandao to block (#3372; ec6a754).
  • Added Polygon Amoy testnet (#4645; 1717abb).
  • Added Chainstack provider (#2741; 014004d).
  • Added deep convertion to Result for toObject and toArray (#4681; 03bfe2a).
  • Added EIP-4844 broadcast support (92bad88).
  • Fix ignored throttle parameters (#4663; 12772e9).

ethers/v6.11.1 (2024-02-14 13:13)

  • Throw an error when attempting to derive from a master path from a non-master node (#4551; 556fdd9).
  • Allow ENS wildcards with labels up to 255 bytes wide; discussed with ENS and deemed safe (#4543; 7f14bde).
  • Enforce string is passed to toUtf8Bytes (#4583; f45bb87).
  • Fix transaction.index not being populated on some backends (#4591; 7f0e140).

ethers/v6.11.0 (2024-02-08 20:26)

... (truncated)

Commits
  • a4b1d1f Update ws package to address possible DoS vulnerability.
  • 16b8e18 docs: fixed paragraph leaking into code in migration docs
  • 9276187 admin: updated dist files
  • 90c196a Fix missing return for Result proxy (#4681).
  • 5b8781d admin: updated dist files
  • e97ca3b Merge branch 'wip-6.13'
  • c2d5346 tests: added gasless testcase for RicMoo-controlled domain
  • 0f1434b admin: remove deprecated mumbai network from tests.
  • 33bb0bf Added Options for BrowserProvider (#4707).
  • 2d2572a admin: update dist files
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependency [ethers](https://github.com/ethers-io/ethers.js). These dependencies need to be updated together.


Updates `ws` from 8.5.0 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.5.0...8.17.1)

Updates `ethers` from 6.6.0 to 6.13.1
- [Release notes](https://github.com/ethers-io/ethers.js/releases)
- [Changelog](https://github.com/ethers-io/ethers.js/blob/main/CHANGELOG.md)
- [Commits](ethers-io/ethers.js@v6.6.0...v6.13.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: ethers
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 16, 2024
Copy link

socket-security bot commented Jul 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@noble/[email protected] None 0 1.35 MB paulmillr
npm/@noble/[email protected] None 0 747 kB paulmillr
npm/[email protected] network +1 16.3 MB ricmoo
npm/[email protected] environment, network 0 141 kB lpinca

🚮 Removed packages: npm/@noble/[email protected], npm/@noble/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

github-actions bot commented Jul 16, 2024

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 78870df

coverage: 49.8% of statements across all listed packages
coverage:  63.4% of statements in consensus/istanbul
coverage:  42.8% of statements in consensus/istanbul/announce
coverage:  55.6% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.5% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

Copy link

github-actions bot commented Jul 16, 2024

5887 passed, 45 skipped

@palango palango merged commit 78870df into master Jul 18, 2024
27 checks passed
@palango palango deleted the dependabot/npm_and_yarn/e2e_test/ethersjs-api-check/multi-d371db0872 branch July 18, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant