Add retry to Protocol Tests Prepare #10501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarof2
approved these changes
Aug 17, 2023
soloseng
reviewed
Sep 15, 2023
| @@ -251,6 +251,8 @@ jobs: | |||
| with: | |||
| node-version: 12.22.11 | |||
| - name: Generate devchain of previous release | |||
| timeout_minutes: 30 | |||
There was a problem hiding this comment.
shouldn't this be specifying using nick-fields/retry@v2
i'd expect something like this (?):
uses: nick-fields/retry@v2
with:
timeout_minutes: 30
max_attempts: 3
auto-merge was automatically disabled
November 17, 2023 12:37
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a flaky segfault that happens, for example here:
https://github.com/celo-org/celo-monorepo/actions/runs/5872083716/job/15923694402
If this works next step will be to add this as required for merge on GitHub