Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Governance Tests #10697

Merged
merged 21 commits into from
Dec 20, 2023
Merged

Migrate Governance Tests #10697

merged 21 commits into from
Dec 20, 2023

Conversation

mcortesi
Copy link
Contributor

@mcortesi mcortesi commented Nov 3, 2023

Migrate governance tests

Updates celo-foundry

Fixed #10678

@mcortesi mcortesi requested a review from a team as a code owner November 3, 2023 01:22
@mcortesi mcortesi requested review from a team November 3, 2023 01:22
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c54712a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcortesi mcortesi requested a review from pahor167 November 3, 2023 01:22
@mcortesi mcortesi marked this pull request as draft November 3, 2023 01:23
@mcortesi mcortesi marked this pull request as ready for review November 3, 2023 13:11
pahor167
pahor167 reviewed Nov 3, 2023
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
pahor167
pahor167 reviewed Nov 20, 2023
View reviewed changes
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/network/Governance.t.sol Outdated Show resolved Hide resolved
@soloseng soloseng self-assigned this Dec 6, 2023
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Dec 6, 2023 •
edited
Loading

Migrate Governance Tests

Generated at commit: 16450c687469c01a7c56859956b8de3b6bb47526

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

martinvol
martinvol approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@martinvol martinvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of Nits but for the most part ready to go!

@soloseng soloseng enabled auto-merge (squash) December 20, 2023 15:51
@mcortesi mcortesi requested a review from a team as a code owner December 20, 2023 16:51
@mcortesi mcortesi requested a review from lvpeschke December 20, 2023 16:51
@soloseng soloseng merged commit f7981a4 into master Dec 20, 2023
26 checks passed
@soloseng soloseng deleted the mcortesi/foundry branch December 20, 2023 20:14
lvpeschke pushed a commit that referenced this pull request Feb 26, 2024
@mcortesi @soloseng @lvpeschke
Migrate Governance Tests (#10697)
84bbb54 
* Use celo-org/celo-foundry

* Migrate Governance Tests to foundry

* fix isVoting tests

* remove governance typescript tests

* remove references to GovernanceTest

* fix submodule path

* updated yarn

* ∆ test contract name

* PR comments

* format

* removed unused

* PR feedback

* Added getHotfixHash function to governace contract

---------

Co-authored-by: soloseng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soloseng soloseng soloseng left review comments

@pahor167 pahor167 pahor167 left review comments

@martinvol martinvol martinvol approved these changes

@lvpeschke lvpeschke lvpeschke approved these changes

Assignees

@soloseng soloseng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/governance/network/governance.ts
5 participants
@mcortesi @martinvol @lvpeschke @pahor167 @soloseng