Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aliases releasecelo to releasegold #10790

Merged
merged 9 commits into from
Dec 8, 2023
Merged

aliases releasecelo to releasegold #10790

merged 9 commits into from
Dec 8, 2023

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Nov 28, 2023

Description

releasegold made sense when celo gold was the token name, but since that was changed to just celo (years ago) its easier to think of these commands as releasing celo.

Other changes

replace gold with celo in places intended for human consumption

Tested

Related issues

Backwards compatibility

yes

Documentation

set

@aaronmgdr aaronmgdr requested review from a team as code owners November 28, 2023 09:40
@aaronmgdr aaronmgdr requested review from a team and jcortejoso November 28, 2023 09:40
Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 18b184c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@celo/celocli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth creating an issue tracking any docs that need updating after this PR.

Few that come to mind:

@aaronmgdr
Copy link
Member Author

Im putting this on the backburner as i cant figure out why the celocli docs are different on ci. maybe to do with using a symlink? idk but this was just a ticket i pulled in thinking it would be quick not high priority

@aaronmgdr aaronmgdr enabled auto-merge (squash) December 8, 2023 10:08
@aaronmgdr aaronmgdr merged commit bb3cf9f into master Dec 8, 2023
34 of 35 checks passed
@aaronmgdr aaronmgdr deleted the aaronmgdr/cli-alias branch December 8, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alias "celocli releasegold" commands to also work for "celocli releasecelo"
2 participants