Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foundry Release gold test #10795

Merged
merged 38 commits into from
Mar 12, 2024
Merged

Foundry Release gold test #10795

merged 38 commits into from
Mar 12, 2024

Conversation

pahor167
Copy link
Contributor

@pahor167 pahor167 commented Nov 28, 2023 •
edited
Loading

Description

Foundry Release gold tests migrated from Truffle

Fixes: #10789

@pahor167 pahor167 requested a review from a team as a code owner November 28, 2023 16:42
@pahor167 pahor167 requested a review from a team November 28, 2023 16:42
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2023

⚠️ No Changeset found

Latest commit: 7d78f5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

soloseng
soloseng requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the tests have been grouped into one. I would recommend keeping them separate.

packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/governance/ReleaseGold.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Show resolved Hide resolved
packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol Outdated Show resolved Hide resolved
pahor167 and others added 19 commits January 9, 2024 10:43
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
6891fe0 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
4b2531c 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
49925d9 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
ed6e7de 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
b6973ca 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
31d963e 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
0a35aee 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
53f5b31 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
88cf672 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
84c7200 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
fa33e6b 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
1a1274e 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
aeaaefa 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
f63a2a8 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
8895c46 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
1df4197 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
5ae0dfc 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
12a9253 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/governance/voting/ReleaseGold.t.sol
fd7f50c 
Co-authored-by: soloseng <[email protected]>
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Mar 5, 2024 •
edited
Loading

Foundry Release gold test

Generated at commit: ebf635a3465049bb8d52adeaf7c33cd9c0d11558

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
3
0
15
39
59
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

soloseng
soloseng approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pahor167 pahor167 requested a review from a team as a code owner March 12, 2024 08:44
@pahor167 pahor167 requested review from alvarof2 and removed request for a team March 12, 2024 08:44
@pahor167 pahor167 merged commit 4a6c4ba into master Mar 12, 2024
25 checks passed
@pahor167 pahor167 deleted the pahor/releaseGoldTests branch March 12, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soloseng soloseng soloseng approved these changes

@alvarof2 alvarof2 Awaiting requested review from alvarof2 alvarof2 is a code owner automatically assigned from celo-org/devopsre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/governance/voting/release_gold.ts
2 participants
@pahor167 @soloseng