Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST #10808

Closed
wants to merge 138 commits into from
Closed

TEST #10808

wants to merge 138 commits into from

Conversation

aaronmgdr
Copy link
Member

what

karlb and others added 30 commits June 12, 2023 16:06
* Remove minimum client version set/get/check

According to CIP-53: celo-org/celo-proposals#318

* BlockchainParameters: remove ClientVersion

In the previous commit, all usage of it has been removed. So now we can
remove the state and the initializer params.

* Undo remove ClientVersion from BlockchainParameters

to keep the storage layout identical.

* BlockchainParameters: bump major version

We changed the initializer, so the contract API has changed.
updated github action tests name
to match current circleCI test setup
* added submodules to protocol test matrix

* format

* git submodule checkout in protocol jobs

* Fix protocol cache

* Rebuild protocol package

* Minnor change

---------

Co-authored-by: Javier Cortejoso <[email protected]>
* change default timeout to a variable set by env

* updated authentication test

* PR feedback

* fix optinal timout

* PR feedback

* refactor configs

* updated tests
* Upgrade gyp

* Allow later node-gyp version from 6.0.0 line as well
Bumps [knex](https://github.com/knex/knex) from 2.1.0 to 2.4.0.
- [Release notes](https://github.com/knex/knex/releases)
- [Changelog](https://github.com/knex/knex/blob/master/CHANGELOG.md)
- [Commits](knex/knex@2.1.0...2.4.0)

---
updated-dependencies:
- dependency-name: knex
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Victoria <[email protected]>
* Trigger GH jobs when there are changes in packages/sdk

* Run all the jobs when pushed to master

* Included more test triggers
Check RPC after geth startup to reduce flakiness

This is meant to avoid the following errors that happens across most
(all?) e2e tests from time to time:
```
 Error: Connection refused or URL couldn't be resolved: http://localhost:8545
  at XMLHttpRequest.request.onreadystatechange (/home/circleci/app/node_modules/web3-providers/dist/web3-providers.cjs.js:759:22)
  at XMLHttpRequestEventTarget.dispatchEvent (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request-event-target.ts:44:13)
  at XMLHttpRequest._setReadyState (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request.ts:219:8)
  at XMLHttpRequest._onHttpRequestError (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request.ts:379:8)
  at ClientRequest.<anonymous> (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request.ts:266:37)
  at Socket.socketErrorListener (_http_client.js:406:9)
  at emitErrorNT (internal/streams/destroy.js:92:8)
  at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
  at processTicksAndRejections (internal/process/task_queues.js:80:21)
```

I am not sure this actually works as intended, but I could not reproduce
the problem after this change, anymore. So it is worth testing it out,
as we can easily revert the change or improve the approach.
#10109 did not update the
file as expected by CI. Running `yarn install` provided the expected
lock file.
* Removed terraform (non-public) and celotool commands
* Using gasLimit in hash if present

to make the slasher test work when gasLimit is added to the header in
celo-org/celo-blockchain#2062. This function
will change again as part of
celo-org/celo-blockchain-planning#100.

* Use constant header fields in hash if present

Related to celo-org/celo-blockchain#2124

* Update header hashing for eth compat

Required to support both old headers and Eth-compatible headers.
See celo-org/celo-blockchain-planning#100
CIP-35 support is dropped in Gingerbread, so that hard fork must be
turned off to test CIP-35.
* chore: remove binanceus from usdc configs

* chore: remove bitso and kraken too
* Remove terraform-modules-public package

* Remove terraform library in celotool

* remove reference to deleted packages

* Update cannonical readme

* Updated phone-utils package doc
Update to v8.
Significant change: issues get closed as `not planned` as opposed to `completed`.
* Test error when skipping circleci jobs

* Dummy circleci job

* Run no-changes always
* Updates DB timeout to use .env variable.
 Use constant as fallback

* update ODIS to use env var & constants as fallback

* increase test timeout

* cleanup

* lint fix

* format

* PR comments

* forgotten pr feedback

* happier linter

---------

Co-authored-by: Javier Cortejoso <[email protected]>
Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.13 to 3.9.17.
- [Release notes](https://github.com/patriksimek/vm2/releases)
- [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md)
- [Commits](patriksimek/vm2@3.9.13...3.9.17)

---
updated-dependencies:
- dependency-name: vm2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Victoria <[email protected]>
* Node 18

* update truffle-ganache-ethereumjs dependencies

* fix build errors

* split migration into JS & TS dir

* build with latest node 18.14

* -- ganache.server promise wrapper
∆ ganache.server option format

* ignore migrations_ts js files

* sync with master

* added resolutions

* remove lib

* removed leftover old dependencies

* fixed revert assersion error message

* WIP notes

* WIP todos

* updated web3 & ethereumjs in utils & protocol

* ++ ethereum-cryptography dependency

* Merge branch 'soloseng/fixing-gas-price'

* timeout fix

* -- comments

* Fixed overflow test

* Merge branch 'soloseng/ast-version_fix'

* using istanbul hardfork

* ++ yarn.lock

* update ganache & ethereumjs version

* - removed resolutions
- using fixed node-fetch types version

* built using latest web3

* Updated ganache config

* Specify gas and await tx receipt

* updated dependencies to fix cross-fecth bind error

* updated yarn.lock

* updated node version in circleci docker file

* updated expected error message

* ensure leading 0x instead of trimming

* increased jest version

* Node 18.16.0

* - update node-fetch
- manage migrations folder during build and clean

* yarn installed using node 18.16.0

* Appease linter

* fixed import issue

* use devchain chain copy

* using fixed jest version

* disabled flake-traker

* generated CLI docs

* buypass jest_setup
in phone-number-privacy/combiner

* ignored ts error due to properties mismatch

* ++ @types/node-fetch

* yarn.lock

* using same @types/node-fetch where applicable

* ts-ignored for abort-controller

* Fix broken kit headers test

* temp force exit on contractkit test

* no detectOpenHandles

* Fix cross-fetch jest mocking issues

* lint fix

* disabled verbose logs during testing

* disabled rpc log in protocol test

* Disabled:
- pre-protocol-test-release
- protocol-test-release

* removed disabled jobs from workflow

* supress test logs

* disabled protocol test

* disabling flakey summary

* disabled odis test

* increased resource class to xlarge

* enaled protocol and odis CI test

* re-enabled
pre-protocol-test-release
protocol-test-release

* enable phone-number-privacy test logs

* Fixing mocha issues in celotool tests

* Change node to 18.14.0

* Node 18.14.2

* changed uniswap init code hash

* Revert "changed uniswap init code hash"

This reverts commit e8a0499.

* fix unicode char in datetime format

* Update e2e test docker image

* verbose output

* Pre-review cleanup

* appease linter

* removed dead code
comment cleanup

* deprecate defaultRpcCaller for httpRpcCaller
This allows compatibility with latest web3

* updated ganache-dev command

* appease linter

* updated revert assertion with message

* downgraded truffle

* updated truffle version and config

* add web3*@1.8.2 to resolutions

* Fixed stability test

* removed resolutions

* updated yarn lock

* updated governance/network test revert messages

* updated protocol common test revert assertion msg

* appease linter

* using assertRevertWithReason
in governance/validators

* using assertRevertWithReason in governance/voting

* angry linter

* using assertRevertWithReason in identity/

* fix linter issue

* using `@ethereumjs/rlp` for RLP encoding

* linter fix

* updated web3* dependencies

* specify type of transaction

* removed verbose output

* added `assertRevertWithoutReason()`

* linting fix

* added revert without msg for identity test

* updated deprecated functions

* distinguish between
transaction reverts and view call reverts

* fixed typing ignore

* specified gas, as gas estimations fails

* updated revert message in test

* updated yarn lock

* updated yarn lock again

* change docker image path

* updated revert msg to match contract

* updated docs to match current node version

* tracking issue in comment

* specified chain id

* revert to default verbose output

* removed debud logging

* GH Workflows run in node18 runners

* Force new node cache

* Disable flake-tracker

* prettify

* Updated test to revert with message

* quiet test

* fixed build errors

* updated scripts to better handle ts & js files

* moved `artifactSingleton` file to lib/

* added transaction type when using mento artifacts

* fix Migration test

* allow submodules in e2e matrix

* python2 -> python (3)

* using nvm to switch to node12 for pre-release test

* ∆ to trigger GH action

* ∆ to trigger full test in GH actions

* Using nvm for circleci image

* Do not use nvm with circleci

* use node12 to generate old release devchain

* reset and reinstall before cleaning

* set python2 in release branch

* installed python2

* added log

* removed python2 install script

* set new release tag

* trigger all test

* WIP comments

* trigger all test

* CircleCi Build pre-protocol with node12

* Circle node12 fix

* Adding python 2 and 3 to circleci image

* run devchain from tar in detached mode

* ++ comments

* updated release tag in circleCI config

* Replace pull_request by pull_request_target

* bump MTWdeployer patch version

* testing bypass dryrun

* loggin and force CI run

* removed false param

* revert change and added try catch

* moved await

* added type to tx detail

* included tx type in contract deployment

* increased logging level in ganache and truffle

* specified gas to deployment tx

* removed truffle debug logging

* keep chaincopy

* removed debug logs

* clean up redundant install
++ comment

* revert GH action trigger on current branch push

* remove comments

* remove gas specfication

* updated node version in docs

* unskip migration test

* PR feedback

* revert back to skip

* ∆ forked packages to celo namespace

* reinstalled

* cleanup TODO and comments

* python -> python3

* updated node base images to 18

* python -> python3

* Updated netcat dependency

* Fix build

* Fix build docker

* force GH action test

* removed flake-tracker

---------

Co-authored-by: Daniel Kesler <[email protected]>
Co-authored-by: Javier Cortejoso <[email protected]>
Co-authored-by: Javier Cortejoso <[email protected]>
* Update circleci.yml
* Remove TODOs comments

---------

Co-authored-by: Javier Cortejoso <[email protected]>
* ReleaseGold refund test fix

* gas fix
* removed legacy code

* ∆ PnpSignAction and PnpQuotaService
to non-abstract class

* renamed variable

* removed empty test

* lowered coverage threshold by 3%

* add back legacy accounts table for now (#10450)

* update sdk/identity

* deprecate `endpoint` variable

* removed todo comment

* removed commented var

* increased fetch_depth

* increase all fetch_depth

* ∆ `pull_request_target` to `pull_request`

* bump version

* remove endpoint var from call to ODIS

* decreased code coverage to threshold to 76%

---------

Co-authored-by: Alec Schaefer <[email protected]>
* ReleaseGold refund test fix

* gas fix

* PR comments

* removal of comment

* Cli fix 2
* odis-tracing-node18

* yarn command

* Test again

* Pray

* Pray 2

* Pray 3

* Pray 4

* endpoint traces

* Error trace

* Span in io.ts

* Handle errors - OK

* Fix if

* IO tracing

* Common IO tracing

* Event messages

* Authenticate tracing

* Sign tracing

* Span end

* Span ends

* Controller span

* NodeTracerProvider

* Trace names

* Instrumentations

* No ExpressInstrumentation

* Remove parentSpan

* Request

* Ignore paths

* parentSpan

* Ignore more paths

* knex instrumentation

* Knex instrumentation

* Full node inst + manual

* ignoreIncomingPaths for http inst

* Comments

* No cache build

* Common packages

* TSlint error 1

* TSlint error 2

* TSlint errors

* TSlint errors shorthand

* // tslint:disable-next-line:no-floating-promises

* Fix tests?
pahor167 and others added 26 commits November 20, 2023 10:25
* Verify smart contracts

* yarn lock

* yarn
* chore: adds commands for pre-releasing

* nit: improves description
* EscrowTest working

* gitmodule update

* update of submodule

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* PR comments

* upper cases

* removal of escrow js tests

* Update packages/protocol/test-sol/Escrow.t.sol

Co-authored-by: soloseng <[email protected]>

* PR comments 2

---------

Co-authored-by: soloseng <[email protected]>
* chore: run npm publish --dry-run

* fix: run npm publish
* ensure origin master is tracked so pre push script works

* Release to npm is only accurate when closing a version packges pr. this is more accurate

* clear that it could do 1 of 2 things
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fix(scripts): fixes typo in package.json script

The script "beta-enter" should run the script `scripts/beta-mode.sh` not `scripts/beta-enter.sh` (which doesn't exist)
* Mark MetaTransactionWallet + Deployer as deprecated.

* include notice in the release notes
Based on @eelanagaraj's PR
https://github.com/celo-org/celo-monorepo/pull/10354/files

New mode that simulates contract calls.
Additionally:
- cleans up some obsolete code
- provides additional informational context for the --client-count parameter
- refactors the simulateClient method and extracts some shared parameters of
  the load test from the main loop
Attestations/Federated attestations test
Extract function signature test
* Odis payments test

* Rename of file
Bumps [get-func-name](https://github.com/chaijs/get-func-name) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases)
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2)

---
updated-dependencies:
- dependency-name: get-func-name
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Victoria <[email protected]>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.4 to 7.23.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Victoria <[email protected]>
* use @celo/celo-devchain package to as initial chain state rather than building it each time.

* use new devchain

* testing w/ contracts artifacts in devchain package

* Bump version fix

* bump celo-devchain version

* BUMP celo-devchain to stable version

* add back log feedback
more accurate const names
fix versions

* LockedGold.getTotalPendingWithdrawalsCount requires contracts to be deployed at a higher version than us currently latest on celo mainnet.

so note this to help developers understand why instead of just a VM revert message

* dont ignore transaction-uri tests, these only take 3 seconds so its not worth separating them out.

* bump celo/devchain version

* latest beter all around

---------

Co-authored-by: soloseng <[email protected]>
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Victoria <[email protected]>
* Address sorted linked list with median Foundry test

* PR comments
* fix: add StableTokens to unversioned contracts list

* feat: add celocli changeset

* Update new-queens-smoke.md

minor would be a new feature

---------

Co-authored-by: Aaron DeRuvo <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Identity Proxy Test

* Identity proxy hub

* gitmodules

* attestations basic

* celo foundry update

* celo foundry update v2

* Attestions.t buildable and few tests migrated

* some tests working

* Attestation tests

* FederatedAttestation tests

* OdisPayments

* attestations spelling fixes

* more spelling fixes

* remoal of ts tests

* Federated attestations removal of warnings

* ExtractFunctionSignatureTest

* AddressSortedLinkedListWithMedian

* PR comments 2

* revert of submodule

* Split into multiple PRs

* Revert of other tests
* Accounts foundry test

* rest of the tests

* Removal of accounts.ts

* Update packages/protocol/test-sol/Accounts.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Accounts.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Accounts.t.sol

Co-authored-by: soloseng <[email protected]>

* Update packages/protocol/test-sol/Accounts.t.sol

Co-authored-by: soloseng <[email protected]>

* PR comments

* PR comments 2

* PR comments 3

* Move of tests into different folder structure

---------

Co-authored-by: soloseng <[email protected]>
Copy link

changeset-bot bot commented Dec 5, 2023

⚠️ No Changeset found

Latest commit: 53c9529

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@celo/ganache 7.8.0-unofficial.0 network, filesystem, shell, environment +3 213 MB soloseng
@celo/odis-identifiers 1.0.0 None +0 3.98 kB app-tooling
@celo/dev-utils 0.0.1 None +55 322 MB app-tooling
@celo/ethereumjs-vm 6.4.1-unofficial.0 environment +1 1.1 MB soloseng
typechain-target-ethers-v5 5.0.1 None +6 346 kB zemse
@celo/wallet-hsm 5.1.1 None +3 31.8 kB app-tooling
@celo/network-utils 5.0.5 None +1 111 kB aaron-clabs
@celo/wallet-hsm-azure 5.1.1 None +14 780 kB app-tooling
rimraf 5.0.5 filesystem, shell, environment +16 2.64 MB isaacs
@summa-tx/memview.sol 1.1.0 None +0 41.4 kB prestwich
@celo/governance 5.0.6 None +24 1.59 MB app-tooling
@celo/phone-utils 6.0.0 None +6 878 kB app-tooling
@celo/wallet-ledger 5.1.1 None +13 770 kB app-tooling
@celo/wallet-remote 5.1.1 None +50 2.34 MB app-tooling
@celo/explorer 5.0.6 None +30 1.57 MB app-tooling
@wagmi/cli 1.5.2 eval, network, filesystem, shell, environment +182 480 MB awkweb
@oclif/parser 3.8.17 None +0 36.3 kB salesforce-releases
truffle-plugin-verify 0.6.5 None +68 109 MB rkalis
web3-utils 1.10.3 None +2 415 kB jdevcs
viem 1.5.4 network +22 13.6 MB jmoxey
@ethereumjs/rlp 5.0.0 None +0 135 kB holgerd77
@celo/celo-devchain 6.0.3-beta.1 None +24 127 MB soloseng
@changesets/cli 2.26.2 filesystem, shell, environment +76 7.74 MB changesets-release-bot
typechain 4.0.3 None +2 148 kB ethereum-ts-bot
humanize-duration 3.31.0 None +0 72.4 kB evanhahn
@ethereumjs/util 8.1.0 None +1 247 kB holgerd77
@celo/cryptographic-utils 4.1.1...5.0.6 None +4/-0 563 kB app-tooling
@celo/typechain-target-web3-v1-celo 0.2.0...1.0.0 None +6/-4 308 kB aaron-clabs
husky 3.1.0...8.0.3 None +0/-5 6.44 kB typicode
@types/humanize-duration 3.27.1...3.27.2 None +0/-0 7.22 kB types
@celo/identity 4.1.1...5.1.1 None +122/-233 10.3 MB app-tooling
@types/debug 4.1.7...4.1.12 None +0/-0 6.45 kB types

🚮 Removed packages: @babel/[email protected], @celo/[email protected], @celo/[email protected], @celo/[email protected], @octokit/[email protected], @octokit/[email protected], @octokit/[email protected], @soloseng/[email protected], @soloseng/[email protected], @types/[email protected], @types/[email protected], @types/[email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Native code @celo/ganache 7.8.0-unofficial.0

Next steps

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@aaronmgdr aaronmgdr closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.