Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GasPriceMinimum Foundry Migration #10811

Merged
merged 20 commits into from
Dec 18, 2023
Merged

GasPriceMinimum Foundry Migration #10811

merged 20 commits into from
Dec 18, 2023

Conversation

soloseng
Copy link
Contributor

@soloseng soloseng commented Dec 5, 2023 •
edited
Loading

Description

Migration of the GasPriceMinimum contracts tests to foundry.

Other changes

  • Added v4.4.2 version of openzeppelin submodule.

  • Added latest version of celo-foundry that supports solidity contracts with pragma 0.8.0

Tested

uint tested

Related issues

@soloseng soloseng requested a review from a team as a code owner December 5, 2023 17:07
@soloseng soloseng requested a review from a team December 5, 2023 17:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d9191bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@soloseng soloseng self-assigned this Dec 5, 2023
@soloseng
added Registry8 test
815b6f0
@soloseng
Using Registry interface instead.
47a9cf2 
Avoids upgrading the registry contract to pragma ^0.8.0 in the PR.
@openzeppelin-code OpenZeppelin Code
Copy link

GasPriceMinimum Foundry Migration

Generated at commit: 47a9cf28b2cfa287808b49a2d35490b27c8b0237

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@soloseng soloseng enabled auto-merge (squash) December 18, 2023 17:01
@soloseng soloseng merged commit 6217f99 into master Dec 18, 2023
35 checks passed
@soloseng soloseng deleted the soloseng/gaspriceminimum-foundry-migration branch December 18, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvol martinvol martinvol approved these changes

Assignees

@soloseng soloseng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/common/gaspriceminimum.ts
2 participants
@soloseng @martinvol