Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metadata-crawler dockerfile. Refactor container workflows #10831

Merged
merged 6 commits into from
Dec 14, 2023

Conversation

jcortejoso
Copy link
Member

@jcortejoso jcortejoso commented Dec 14, 2023

Description

Blockscout metadata crawler is still an in-use tool to fetch celo explorer metadata from validators and validator groups.
The dockerfile for this was deleted (by error) in #10124.

This PR aims to restore the dockerfile, with optimizations/refactoring to reduce the number of packages and dependencies included and also having an updated image with reduced present vulnerabilities.

Apart from that, I've unified different container-* workflows in a single containers.yaml workflow, trying to improve readability and maintainability.

Tested

Tested in baklava. It executed correctly (although there were not any metadata change, but I expect to work normally).

Backwards compatibility

No backwards compatibility issue detected

@jcortejoso jcortejoso requested a review from a team as a code owner December 14, 2023 08:39
Copy link

changeset-bot bot commented Dec 14, 2023

⚠️ No Changeset found

Latest commit: d08f583

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aaronmgdr
Copy link
Member

aaronmgdr commented Dec 14, 2023

hmmi was thinking the meta data crawler was close to deprecated and had included it in the packages moved #10829 to the new repo for sdks. (with the thought that it would be removed in the next few months)

Do you want it to remain in the monorepo? where you could then move it to it own repo if its being kept around.

@jcortejoso
Copy link
Member Author

hmmi was thinking the meta data crawler was close to deprecated and had included it in the packages moved to the new repo for sdks. (with the thought that it would be remove in the next few months)

Do you want it to remain in the monorepo? where you could then move it to it own repo if its being kept around.

Talked with Valentin and seem we still need it. It is probably only on maintainability mode and we won't be working on new features, so I'd expect very little job on its code (if any).

We can move to its own repo it that will make easier monorepo work.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jcortejoso jcortejoso enabled auto-merge (squash) December 14, 2023 10:31
@jcortejoso jcortejoso requested a review from lvpeschke December 14, 2023 10:34
.github/workflows/containers.yaml Outdated Show resolved Hide resolved
.github/workflows/containers.yaml Outdated Show resolved Hide resolved
@jcortejoso jcortejoso merged commit b207e22 into master Dec 14, 2023
44 checks passed
@jcortejoso jcortejoso deleted the jcortejoso/metadatacrawler_dockerfile branch December 14, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants