-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added metadata-crawler dockerfile. Refactor container workflows #10831
Conversation
|
hmmi was thinking the meta data crawler was close to deprecated and had included it in the packages moved #10829 to the new repo for sdks. (with the thought that it would be removed in the next few months) Do you want it to remain in the monorepo? where you could then move it to it own repo if its being kept around. |
Talked with Valentin and seem we still need it. It is probably only on maintainability mode and we won't be working on new features, so I'd expect very little job on its code (if any). We can move to its own repo it that will make easier monorepo work. |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Description
Blockscout metadata crawler is still an in-use tool to fetch celo explorer metadata from validators and validator groups.
The dockerfile for this was deleted (by error) in #10124.
This PR aims to restore the dockerfile, with optimizations/refactoring to reduce the number of packages and dependencies included and also having an updated image with reduced present vulnerabilities.
Apart from that, I've unified different
container-*
workflows in a singlecontainers.yaml
workflow, trying to improve readability and maintainability.Tested
Tested in baklava. It executed correctly (although there were not any metadata change, but I expect to work normally).
Backwards compatibility
No backwards compatibility issue detected