-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@celo/abis and @celo/contracts should not be available to publish by default #10832
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defensive coding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need something that doesnt error out but also wont accidently publish
i feel like i remember having an issue setting private: false, before where it would complain that it should just be removed. maybe that was just a lint and not an real isssue. |
Description
This PR sets removes
version
and marks as private@celo/abis
and@celo/contracts
packages to avoid releasing valid version by mistake.Other changes
None.
Tested
Ran
RELEASE_VERSION=10.0.0-local yarn prepare_contracts_and_abis_publishing
to see if it still replaces versions inpackage.json
and it does (as well as marks the packages as public).Ran
yarn prepare_contracts_and_abis_publishing
to see if it doesn't replace versions inpackage.json
and it doesn't. It also keeps the packages private.Ran the workflow manually and noticed that package has been released with provided tag. For automated runs after commits it didn't release anything as expected.
Backwards compatibility
It's backwards compatible.
Documentation
None.