[TA-2785] List variables command #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaberionAjvazi
requested review from
GencBlakqoriP9 and
a team
as code owners
jetakasabaqi
previously approved these changes
Jan 29, 2024
# Conflicts: # src/api/batch-import-export-api.ts # src/commands/config.command.ts # src/content-cli-config.ts # src/interfaces/package-export-transport.ts # src/services/studio/studio.service.ts
promeris
approved these changes
Jan 30, 2024
ZgjimHaziri
approved these changes
Jan 31, 2024
jetakasabaqi
approved these changes
Jan 31, 2024
Buqeta
approved these changes
Jan 31, 2024
ksalihu
reviewed
Jan 31, 2024
| private async buildKeyVersionPairs(keysByVersion: string[], keysByVersionFile: string): Promise<PackageKeyAndVersionPair[]> { | ||
| let variablesExportRequest: PackageKeyAndVersionPair[] = []; | ||
|
|
||
| if (keysByVersion.length) { |
There was a problem hiding this comment.
Please compare numbers to numbers. I think it makes it more explicit what we are comparing, instead of relying on truthy values.
Suggested change
| if (keysByVersion.length) { | |
| if (keysByVersion.length !== 0) { |
| expect(variableExportRequest).toEqual(packageKeyAndVersionPairs); | ||
| }) | ||
|
|
||
| it("Should throw error if no mapping or file path is provided", async () => { |
There was a problem hiding this comment.
I think the test name should be Should throw error if no mapping and no file path is provided
|
|
||
| if (keysByVersion.length) { | ||
| variablesExportRequest = this.buildKeyAndVersionPairsFromArrayInput(keysByVersion); | ||
| } else if (!keysByVersion.length && keysByVersionFile.length) { |
There was a problem hiding this comment.
i think keysByVersionFile.length should be keysByVersionFile !== "", right?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added command to list variables for packages by key and version.
The command can be used to list package variables for given keys and version. It has an optional --json param which can be used to export the variables as json instead of just listing in the console.
Checklist