ceph-releases/ALL/centos/daemon-base: change hardcoded nfs-ganesha ve… #2153
Conversation
…rsion Change hard-coded nfs-ganesha version V5.3.2 to V5.5. We are currently pinning the daily nfs-ganesha builds to V5.5 in https://jenkins.ceph.com/job/nfs-ganesha
There was a problem hiding this comment.
What about reef, quincy, and pacific? We should decide on that too.
Also, @guits had refactord the nfs-ganesha repo with this commit:
b86898a
But I had to revert it in #2151 since it caused a regression in our container scripts (see more details about the regression in https://pad.ceph.com/p/16.2.14-struggles).
@guits mentioned he wants to reintroduce this change; @guits do you agree it could be handled in a subsequent PR?
| @@ -3,7 +3,7 @@ yum install -y jq && \ | |||
| bash -c ' \ | |||
| if [ -n "__GANESHA_PACKAGES__" ]; then \ | |||
| if [[ "${CEPH_VERSION}" == master || "${CEPH_VERSION}" == main ]]; then \ | |||
| curl -s -L "https://shaman.ceph.com/api/repos/nfs-ganesha/V5.3.2/latest/centos/__ENV_[DISTRO_VERSION]__/flavors/ceph_main/repo?arch=$(arch)" -o /etc/yum.repos.d/ganesha.repo ; \ | |||
| curl -s -L "https://shaman.ceph.com/api/repos/nfs-ganesha/V5.5/latest/centos/__ENV_[DISTRO_VERSION]__/flavors/ceph_main/repo?arch=$(arch)" -o /etc/yum.repos.d/ganesha.repo ; \ | |||
There was a problem hiding this comment.
@ljflores I think we should test ceph devel builds with nfs-ganesha devel builds
There was a problem hiding this comment.
@kalebskeithley thoughts?
@guits in that case, we'd have to add something to the nfs-ganesha Jenkins job so it periodically builds "next" as well as V5.5: https://github.com/ceph/ceph-build/blob/main/nfs-ganesha/config/definitions/nfs-ganesha.yml
There was a problem hiding this comment.
'next' is the bleeding edge devel branch. It's not really suitable, IMO, to be used. For anything
If you use a 'next' branch build and something doesn't work we may or may not make it a priority to fix.
I strongly suggest you use only released/tagged VX.Y versions, e.g. V5.5, V5.6, etc. V5.Y is perfectly fine for pacific, quincy, reef, and beyond.
I don't understand the comment that you need to build 'next' occasionally. Why?
There was a problem hiding this comment.
In that case, let's stick with V5.5.
Are you okay with merging this change first and seeing if we get a good build from it? Then I'll get a PR for the others. |
|
Sure |
…rsion
Change hard-coded nfs-ganesha version V5.3.2 to V5.5.
We are currently pinning the daily nfs-ganesha builds to V5.5 in https://jenkins.ceph.com/job/nfs-ganesha