Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete files in /usr/lib64/systemd for centos 9 images #2204

Merged
merged 1 commit into from
May 3, 2024

Conversation

jagombar
Copy link
Contributor

@jagombar jagombar commented May 1, 2024

When starting up a cluster from a centos 9 based container image, the following entries are logged multiple times:
ceph-volume.log:[2024-05-01 15:28:51,612][ceph_volume.process][INFO ] stderr /usr/sbin/udevadm: error while loading shared libraries: libsystemd-shared-252.so: cannot open shared object file: No such file or directory

Further investigation showed that the Dockerfile for centos 9 was deleting everything in /usr/lib64/systemd/ because it is built from the default /src/DOCKERFILE_CLEAN_COMMON. I think that centos 9 should be keeping the files in this directory in the same way that centos 8 does.

Description of your changes:

Moved /8/DOCKERFILE_CLEAN_COMMON into its parent directory. Considered copying the file into the /9/ subdirectory, but that seemed unnecessary.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Documentation has been updated, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.

@cbodley cbodley requested a review from dmick May 1, 2024 18:13
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks exactly right, but also needs to be done in the centos-arm64 directory

When starting up a cluster from a centos 9 based container image, the following entries are logged multiple times:
  ceph-volume.log:[2024-05-01 15:28:51,612][ceph_volume.process][INFO  ] stderr /usr/sbin/udevadm: error while loading shared libraries: libsystemd-shared-252.so: cannot open shared object file: No such file or directory

Further investigation showed that the Dockerfile for centos 9 was deleting everything in /usr/lib64/systemd/ because it
is built from the default /src/__DOCKERFILE_CLEAN_COMMON__.  I think that centos 9 should be keeping the files in this
directory in the same way that centos 8 does.

Signed-off-by: John Agombar <[email protected]>
@jagombar
Copy link
Contributor Author

jagombar commented May 2, 2024

ah yes, I completely missed that. Fixed now.

@dmick dmick merged commit 6273042 into ceph:main May 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants