Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squid: add gmonitoring package #2238

Merged
merged 3 commits into from
Sep 24, 2024
Merged

squid: add gmonitoring package #2238

merged 3 commits into from
Sep 24, 2024

Conversation

guits
Copy link
Collaborator

@guits guits commented Sep 16, 2024

nfs-ganesha 6 introduced a new RPM gmonitoring.
This commit includes this new package into the Ceph Squid container image.

@ktdreyer
Copy link
Member

I tested this and it will not impact ubi9, because ubi9 uses src/daemon-base/__GANESHA_PACKAGES__.

What if we delete ceph-releases/squid/centos/__GANESHA_PACKAGES__ and just use src/daemon-base/__GANESHA_PACKAGES__?

It would simplify things to avoid hard-coding the ganesha version numbers in each individual package entry.

@guits
Copy link
Collaborator Author

guits commented Sep 19, 2024

I tested this and it will not impact ubi9, because ubi9 uses src/daemon-base/__GANESHA_PACKAGES__.

yeh, that was exactly what I suspected.

What if we delete ceph-releases/squid/centos/__GANESHA_PACKAGES__ and just use src/daemon-base/__GANESHA_PACKAGES__?

It would simplify things to avoid hard-coding the ganesha version numbers in each individual package entry.

That should do the job, indeed.

tserlin
tserlin approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@tserlin tserlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guits guits added the DNM label Sep 19, 2024
@guits guits removed the DNM label Sep 20, 2024
@guits
Copy link
Collaborator Author

guits commented Sep 20, 2024 •
edited
Loading

@ktdreyer is this package built for arm64 ?

@guits guits force-pushed the add-gmonitoring branch 9 times, most recently from adaa433 to 28985bc Compare September 20, 2024 14:58
@guits
Copy link
Collaborator Author

guits commented Sep 20, 2024

@ktdreyer while working on this PR, I noticed we have no RPM built here: https://download.ceph.com/rpm-quincy/el9/aarch64/

@guits guits requested a review from ktdreyer September 23, 2024 13:24
@ktdreyer
Copy link
Member

I noticed we have no RPM built here: https://download.ceph.com/rpm-quincy/el9/aarch64/

That's an interesting data point. I'm not involved with building those, and I think it means we don't support that upstream.

ktdreyer
ktdreyer approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ktdreyer ktdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the following:

BRANDING=redhat VERSION=7 ./contrib/compose-rhcs.sh
BRANDING=redhat VERSION=8 ./contrib/compose-rhcs.sh
BRANDING=ibm VERSION=8 ./contrib/compose-rhcs.sh

The output looks like I expect. Thanks!

@guits
tests: build quincy, reef and squid for arm64
dc8a84d 
There's no more reason for not testing Ceph Reef and Squid
with arm64 builds.

For some reasons, Ceph Quincy arm64 RPMs aren't available.

Signed-off-by: Guillaume Abrioux <[email protected]>
@guits
squid: bump to nfs-ganesha 6.0
528a753 
Bump to nfs-ganesha 6.0

Signed-off-by: Guillaume Abrioux <[email protected]>
@guits
squid: add gmonitoring package
443ea41 
nfs-ganesha 6 introduced a new RPM `gmonitoring`.
This commit includes this new package into the Ceph Squid container
image.

Signed-off-by: Guillaume Abrioux <[email protected]>
@guits guits merged commit 2842c06 into main Sep 24, 2024
12 checks passed
@guits guits deleted the add-gmonitoring branch September 24, 2024 07:11
@ktdreyer ktdreyer mentioned this pull request Sep 24, 2024
Closed
@travisn travisn mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktdreyer ktdreyer ktdreyer approved these changes

@tserlin tserlin tserlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guits @ktdreyer @tserlin