Add CephCluster API (cephclusters.csi.ceph.io) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
reviewed
Jul 3, 2024
API generated using the following command: "kubebuilder create api --group csi --version v1alpha1 --kind CephCluster" Signed-off-by: nb-ohad <[email protected]>
nb-ohad
force-pushed
the
ceph-cluster-api
branch
from
f51fade
to
7134c23
Compare
Madhu-1
approved these changes
Jul 10, 2024
|
While recognizing naming is still up for discussion, please let's rename this one sooner than later to avoid naming collisions of the short names with our own types, the CephCluster of Rook. If you're really going for simple, how about |
|
@travisn I agree, we do need to change that sooner rather than later. |
|
leelavg
pushed a commit
to leelavg/ceph-csi-operator
that referenced
this pull request
Sep 18, 2024
Bug 2307835: Add log rotation for the CephCSI pods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Adds new API named CephCluster (cephcluster.csi.ceph.io), capturing the setting needed to configure Ceph CSI to connect to a single Ceph Cluster
The PR does not include CRD field validation rules.
This will be resolved in a future PR
Is there anything that requires special attention
No
Future concerns
There is still an active discussion around API naming and at the time of this PR we are still open to future name changes