Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: let's clone repo with depth 1 #29

Merged
merged 2 commits into from
Jul 2, 2024
Merged

ci: let's clone repo with depth 1 #29

merged 2 commits into from
Jul 2, 2024

Conversation

subhamkrai
Copy link
Contributor

let's clone repo with depth 1 which baiscally
fetch just gets the branch tips and no prior history.

Describe what this PR does

Provide some context for the reviewer

Is there anything that requires special attention

Do you have any questions?

Is the change backward compatible?

Are there concerns around backward compatibility?

Provide any external context for the change, if any.

For example:

  • Kubernetes links that explain why the change is required
  • Ceph-CSI spec related changes/catch-up that necessitates this patch
  • golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.

Fixes: #issue_number

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide
    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes

    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@subhamkrai subhamkrai marked this pull request as ready for review July 2, 2024 11:56
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo's in commit message

let's  clone repo with depth 1 which basically
fetch just gets the branch tips and no prior history.

Signed-off-by: subhamkrai <[email protected]>
After discussion, we decided to run ci on push event for now

Signed-off-by: subhamkrai <[email protected]>
@subhamkrai subhamkrai requested a review from Madhu-1 July 2, 2024 12:18
@Madhu-1 Madhu-1 merged commit 0125454 into ceph:main Jul 2, 2024
5 checks passed
leelavg pushed a commit to leelavg/ceph-csi-operator that referenced this pull request Sep 18, 2024
downstream: fix bundle generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants