ci: Adding gosec in golangci lint

[subhamkrai]

Describe what this PR does

ci: add gosec in golangci lint check

adding gosec in golangci lint check, also skip gosec G204 as we don't
want to run gosec on exec method

Checklist:

• Commit Message Formatting: Commit titles and messages follow
  guidelines in the developer
  guide.
• Reviewed the developer guide on Submitting a Pull
  Request
• Pending release
  notes
  updated with breaking and/or notable changes for the next major release.
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.

[nb-ohad]

@subhamkrai Can you please expend on the reason to disable G204?

[subhamkrai]

@subhamkrai Can you please expend on the reason to disable G204?

@nb-ohad gosec G204 gives error when subprocess is started with in the a process, like exec.Command and in other repos also upstream I have seen they suggesting to either disable gosec on that line or disable G204

[Madhu-1]

@subhamkrai we should not disable the security rules in the whole repo, if required disable it by adding a comment where it is used or disable it in the test files (if possible)

[subhamkrai]

@subhamkrai we should not disable the security rules in the whole repo, if required disable it by adding a comment where it is used or disable it in the test files (if possible)

we can disable for single line, but this rule was something I noticed disabled most places

[Madhu-1]

@subhamkrai we should not disable the security rules in the whole repo, if required disable it by adding a comment where it is used or disable it in the test files (if possible)

we can disable for single line, but this rule was something I noticed disabled most places

these kind of rules need to be verified and disable on demand based on the impact, For now lets not disable it by default rather disable it by putting a comment on the line in code

[subhamkrai]

@subhamkrai we should not disable the security rules in the whole repo, if required disable it by adding a comment where it is used or disable it in the test files (if possible)

we can disable for single line, but this rule was something I noticed disabled most places

these kind of rules need to be verified and disable on demand based on the impact, For now lets not disable it by default rather disable it by putting a comment on the line in code

there is small problem now, we need to put //nolint:gosec in the same line as exec.command but when exec.command is spilt into multiple lines is failing with G204 but if we keep exec.command golangci lint in same long line it will fail again due to char limit per line again golangci lint is failing

[subhamkrai]

@subhamkrai we should not disable the security rules in the whole repo, if required disable it by adding a comment where it is used or disable it in the test files (if possible)

we can disable for single line, but this rule was something I noticed disabled most places

these kind of rules need to be verified and disable on demand based on the impact, For now lets not disable it by default rather disable it by putting a comment on the line in code

there is small problem now, we need to put //nolint:gosec in the same line as exec.command but when exec.command is spilt into multiple lines is failing with G204 but if we keep exec.command golangci lint in same long line it will fail again due to char limit per line again golangci lint is failing

@Madhu-1 ^

[nb-ohad]

@subhamkrai Where exactly do we have exec.command in the repo? We should not have it in code that runs on production. Do we have something like that in tests or supporting code?

[nb-ohad]

@subhamkrai Can you please fix the lint errors?

[subhamkrai]

@subhamkrai Can you please fix the lint errors?

@nb-ohad misspell error will go away, and for golangCI lint we need to decided how we want to fix as I mentioned

there is small problem now, we need to put //nolint:gosec in the same line as exec.command but when exec.command is spilt into multiple lines is failing with G204 but if we keep exec.command golangci lint in same long line it will fail again due to char limit per line again golangci lint is failing

in above comment

[Madhu-1]

@subhamkrai did you try to add that comment on top of that line?