API renames and validation rules #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp98
reviewed
Jul 29, 2024
sp98
reviewed
Jul 29, 2024
sp98
suggested changes
Jul 29, 2024
Madhu-1
requested changes
Jul 29, 2024
nb-ohad
force-pushed
the
api-renames-and-rules
branch
4 times, most recently
from
a8e8387
to
9a7521a
Compare
Note: Design doc alignment will be provided in a future commit for all API changes together Signed-off-by: nb-ohad <[email protected]>
Note: Design doc alignment will be provided in a future commit for all API changes together Signed-off-by: nb-ohad <[email protected]>
Signed-off-by: nb-ohad <[email protected]>
nb-ohad
force-pushed
the
api-renames-and-rules
branch
from
9a7521a
to
492bc74
Compare
|
@Madhu-1 |
Merged
Signed-off-by: nb-ohad <[email protected]>
Signed-off-by: nb-ohad <[email protected]>
nb-ohad
force-pushed
the
api-renames-and-rules
branch
from
492bc74
to
69af8e6
Compare
|
@Madhu-1 I removed the hold from the PR and addressed all pending review comments. Please feel free to offer another review or to merge |
Madhu-1
approved these changes
Jul 30, 2024
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
The PR contain enhancements to the existing API types:
Is there anything that requires special attention
No
Are there concerns around backward compatibility?
Some non merged work will need to be rebased and code will need to shift from the old API names to the new ones