Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientProfile API: Add support for kernel and fuse mount options #64

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

nb-ohad
Copy link
Collaborator

@nb-ohad nb-ohad commented Jul 29, 2024

Describe what this PR does

Add support for kernel and fuse mount options as optional fields under the .Spec.CephFs field

Is there anything that requires special attention

No

Is the change backward compatible?

Yes

@nb-ohad nb-ohad requested a review from Madhu-1 July 29, 2024 19:26
@nb-ohad nb-ohad force-pushed the clientprofile-enhancements branch from 7165584 to 6fa6fcc Compare July 29, 2024 20:25
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nb-ohad please rebase the PR

api/v1alpha1/clientprofile_types.go Outdated Show resolved Hide resolved
@nb-ohad nb-ohad force-pushed the clientprofile-enhancements branch from 6fa6fcc to d741247 Compare July 30, 2024 07:36
@nb-ohad
Copy link
Collaborator Author

nb-ohad commented Jul 30, 2024

@nb-ohad please rebase the PR

@Madhu-1 rebased

@Madhu-1 Madhu-1 merged commit 55f7513 into ceph:main Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants