-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: distributed tracing in ceph using jaeger blog 2021 #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of things that caught my eye -- I didn't proof-read or anything like that.
frameborder="0" | ||
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" | ||
allowfullscreen | ||
></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, this Bluejeans recording has the screen split into two halves, with the meeting screen on the left and the actual demo on the right. I would suggest something like asciinema instead -- much better suited for blog posts IMO.
...og/2021/distributed-tracing-in-ceph-using-jaeger/distributed-tracing-in-ceph-using-jaeger.md
Outdated
Show resolved
Hide resolved
...og/2021/distributed-tracing-in-ceph-using-jaeger/distributed-tracing-in-ceph-using-jaeger.md
Outdated
Show resolved
Hide resolved
thankyou @idryomov! appreciate your review! will amend it. |
Hi @ideepika 👋 Just a quick heads up re: filenaming. We'll want to ensure the blog post is named This will ensure that the blog appears at Hope that helps |
thanks @adamduncan, have renamed! maybe it must be good to add in github comment while opening a PR :) |
No problem, @ideepika. Blog posts (and most other collected pages, e.g. events, etc.) will need to include frontmatter data to set the title, date, author, etc. for the post. Again, this is documented in the Blog README. Worth referencing the other posts that exist currently to get a feel for how they make use of this, and ensure that this post has the fields required prior to merging. Thanks. |
FYI re: tags: #166 (looking for better ways to document this, so first-time contributors have a clear approach to work to). Appreciate you bearing with us as we get the new site and workflows off the ground 🙂 |
@adamduncan is gif not supported? https://wip-jaeger-blog.ceph.io/en/news/blog/2021/distributed-tracing-in-ceph-using-jaeger/ |
Ah, good spot. You're correct. The site processes all images in the site, to ensure they're optimised. Currently that is handling jpg, png and svg, but not gif. Have opened a ticket (#243), and will try to get that in for you ASAP.
Looks like the To make embedding videos from YouTube easier however, we've created a snippet for use throughout the site (again, we've documented YouTube embed code in the project README). This is the best way to embed videos from YouTube:
|
thanks! :)
Awesome! |
Signed-off-by: Deepika Upadhyay <[email protected]>
@adamduncan thanks! I rebased and repushed but I cannot see gif rendered, am I missing something? https://wip-jaeger-blog.ceph.io/en/news/blog/2021/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to approve this PR. After this PR has been merged, I will make another PR in which I will make a small number of stylistic and syntactic changes.
The "What's Next" section is the only section that requires a rewrite on account of syntactically inadmissible text. Everything else created here is clean enough to be merged proudly.
In the main, this is excellent developer-written documentation.
thanks @zdover23 ! i want to make some changes in master that might be helpful, will merge once these nits are resolved |
@ideepika I don't think so. I'm not sure the branch deploy has rebuilt yet, so the post at https://wip-jaeger-blog.ceph.io/en/news/blog/2021/distributed-tracing-in-ceph-using-jaeger/ still hasn't inherited the GIF fix. FYI — there's an update to the build config in the works ceph/ceph-build#1869 that should ensure PR deploys rebuild, and we can then see the latest. |
Ah, @ideepika, I hadn't realised you've created a new PR for this, based on a fork of the We were still looking at links to your previous (now closed) PR All good. I've reviewed from https://main.ceph.io/en/news/blog/2021/distributed-tracing-in-ceph-using-jaeger/ and can confirm that the blog post is rendering as expected, GIFs and all. Would you like to confirm and merge this PR to make the blog post live when you're ready? |
@adamduncan aah I am so used to named branches, sorry forgot I made a PR again main branch, force pushed wip-jaeger-blog as main |
Is this ready to post? |
@liewegas blog is good to go, but without ceph/ceph#38783 build would fail if someone tries it out, the cmake pr is close to merge I think |
@zdover23 merged the PR, please feel free to update anything relevant. thanks! |
Signed-off-by: Deepika Upadhyay [email protected]