Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preflight: old repos disablement refactor (backport #230) #233

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 12, 2023

This is an automatic backport of pull request #230 done by Mergify.
Cherry-pick of 887b89f has failed:

On branch mergify/bp/pacific/pr-230
Your branch is up to date with 'origin/pacific'.

You are currently cherry-picking commit 887b89f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   cephadm-preflight.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

This refacts the task that disables old repositories.
The speeds up this task which seems to be currently very time consuming.

```
TASK [disable older rhceph repositories if any] ****************************
changed: [localhost] => (item=rhceph-4-tools-for-rhel-8-x86_64-rpms)
changed: [localhost] => (item=rhceph-4-mon-for-rhel-8-x86_64-rpms)
changed: [localhost] => (item=rhceph-4-osd-for-rhel-8-x86_64-rpms)
changed: [localhost] => (item=rhceph-5-tools-for-rhel-8-x86_64-rpms)

PLAY RECAP *****************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

real	3m18.439s
```

```
TASK [disable older rhceph repositories if any] ***********
changed: [localhost]

PLAY RECAP ***********************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

real	0m47.198s
```

Also, this makes sure all previous repositories are disabled for both
el8 and el9.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2181243

Signed-off-by: Guillaume Abrioux <[email protected]>
(cherry picked from commit 887b89f)
This adds the required change in .mergify.yml in order to
automate reef backports with mergify.

Signed-off-by: Guillaume Abrioux <[email protected]>
(cherry picked from commit f279b61)
@asm0deuz asm0deuz merged commit cd25147 into pacific Oct 30, 2023
8 of 9 checks passed
@asm0deuz asm0deuz deleted the mergify/bp/pacific/pr-230 branch October 30, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants