purge: do not purge infra pkgs by default #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test el8-functional |
|
I think rather than introducing some logic/complexity, another approach would be to split ceph_pkgs:
- cephadm
- ceph-common
infra_pkgs:
- chrony
- podmanafter all, this could be valid for |
asm0deuz
force-pushed
the
keep_chrony
branch
3 times, most recently
from
700028f
to
cc83617
Compare
asm0deuz
changed the title
asm0deuz
force-pushed
the
keep_chrony
branch
4 times, most recently
from
93104a4
to
33b3946
Compare
asm0deuz
changed the title
asm0deuz
force-pushed
the
keep_chrony
branch
7 times, most recently
from
447e741
to
59e3d27
Compare
By default infra pkgs will remain installed after the cluster purge as they might already be there at Ceph installation and could be used by other processes on the nodes. Fixes: ceph#239 Signed-off-by: Teoman ONAY <[email protected]>
guits
approved these changes
Dec 4, 2023
This was referenced Dec 4, 2023
asm0deuz
added a commit
that referenced
this pull request
Dec 4, 2023
purge: do not purge infra pkgs by default (backport #260)
asm0deuz
added a commit
that referenced
this pull request
Dec 4, 2023
purge: do not purge infra pkgs by default (backport #260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infra pkgs are mandatory on a ceph node but could be already present before installing Ceph.
At Ceph uninstallation, we will keep them installed
Fixes: #239