Scrape button Added #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey! i added the button kindly check it.
ljflores
reviewed
Sep 18, 2023
pulpito/templates/run.html
Outdated
| @@ -53,7 +53,9 @@ <h2> | |||
| <a href="/{{ run.name }}/detail"> See detail view?</a> | |||
| </h2> | |||
| </div> | |||
|
|
|||
| <h2> | |||
| <a href="http://qa-proxy.ceph.com/teuthology/{{ run.name }}/scrape.log">Want to see scrape.log?</a> | |||
There was a problem hiding this comment.
I would write it like this to keep similar to the other hyperlinks.
Suggested change
| <a href="http://qa-proxy.ceph.com/teuthology/{{ run.name }}/scrape.log">Want to see scrape.log?</a> | |
| <a href="http://qa-proxy.ceph.com/teuthology/{{ run.name }}/scrape.log">See scrape.log?</a> |
keeping similar to the other hyperlinks.
Updated
Adityaakr
commented
Sep 18, 2023
|
@Adityaakr looks like the file was deleted by mistake |
I apologize for that I recreated the review request. @ljflores |
Adityaakr
commented
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###TITLE ###
Add "Scrape" button for quick access to scrape.log
This PR adds a "Scrape" button to the batch run page, providing users with a convenient way to access the scrape.log file. The button links to the correct URL format, including "/teuthology/" for consistency.
Related Issue:
Fixes #88 @kamoltat @ljflores
This change addresses feedback from previous discussions and aligns with the project's URL structure. It improves user experience by simplifying access to important logs.