Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supervisor.reimage(): Improve Sentry reporting #1882

Merged
merged 1 commit into from
Aug 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion teuthology/dispatcher/supervisor.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,11 @@ def reimage(job_config):
ctx.config,
dict(status='dead', failure_reason='Error reimaging machines: ' + str(e))
)
ctx.summary = {'sentry_event': sentry.report_error(job_config, e)}
# There isn't an actual task called "reimage", but it doesn't seem
# necessary to create a whole new Sentry tag for this.
ctx.summary = {
'sentry_event': sentry.report_error(job_config, e, task_name="reimage")
}
nuke.nuke(ctx, True)
# Machine that fails to reimage after 10 times will be marked down
check_for_reimage_failures_and_mark_down(targets)
Expand Down
Loading