teuthology/scrape: Fix bad backtrace parsing in Teuthology.log #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - confusing warning message stating that the back trace is malformed - We kept adding to the backtrace buffer even when we exceeded the `MAX_BT_LINES` Solution: - Correct the warning message to be "Ignoring backtrace that exceeds MAX_BT_LINES" - reset the buffer once we exceeded MAX_BT_LINES - Added some cases where we detect start/end of back trace. Fixes:https://tracker.ceph.com/issues/62445 Signed-off-by: Kamoltat Sirivadhna <[email protected]>
|
The docs build failure should be addressed by sphinx-doc/sphinx#11613 |
|
@zmc Thanks for filing the PR to fix the sphinx issue :) I tried re-running the CI again after sphinx-doc/sphinx#11613 was merged, but it seems to still be failing with the same error :( I wonder if I need to do something more to get the latest update of the patch in my CI |
|
@kamoltat they haven't published a release with the fix yet |
zmc
added a commit
that referenced
this pull request
Aug 23, 2023
See #1884 Signed-off-by: Zack Cerza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
confusing warning message stating that the back trace is malformed
We kept adding to the backtrace buffer even when we exceeded the
MAX_BT_LINESSolution:
Fixes: https://tracker.ceph.com/issues/62445