Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update paramiko #1886

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Update paramiko #1886

merged 1 commit into from
Aug 30, 2023

Conversation

zmc
Copy link
Member

@zmc zmc commented Aug 28, 2023 •
edited
Loading

This intends to fix (among others) this issue: https://sentry.ceph.com/share/issue/e9092ab6059e4ea299350022b9b2cb52/

@zmc
Update paramiko
3a403c0 
Signed-off-by: Zack Cerza <[email protected]>
@zmc
Copy link
Member Author

zmc commented Aug 28, 2023

testing here: https://pulpito-ng.ceph.com/zack-2023-08-28_20:12:06-orch:cephadm:smoke-small-main-distro-default-smithi/

@zmc zmc requested a review from dmick August 28, 2023 23:01
@dmick
Copy link
Member

dmick commented Aug 28, 2023

see paramiko/paramiko#2023

dmick
dmick approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, and maybe even helpful :) but let's wait to merge until early in a workday when we can be around to handle emergencies. paramiko scares me.

@zmc zmc merged commit f9a8556 into main Aug 30, 2023
9 checks passed
@zmc zmc deleted the update-paramiko branch August 30, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmick dmick dmick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmc @dmick