fix cephadmunit start() method #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CephadmUnit.start() method, explicitly pass start_cmd as "args" keyword because Remote.run expects keyword arguments. Fixes: https://tracker.ceph.com/issues/65162 Signed-off-by: Vallari Agrawal <[email protected]>
In CephadmUnit.start() method, `is_started` isn't set to true. When running() is called after start(), then it would return false, which is not correct since the daemon has been started by calling start(). This commit fixes that issue. Signed-off-by: Vallari Agrawal <[email protected]>
zmc
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of problems in CephadmUnit.start() method:
Explicitly pass
start_cmdas "args" keyword because Remote.run expects keyword arguments.Fixes: https://tracker.ceph.com/issues/65162
is_startedisn't set to true. When running() is called after start(), then it wouldreturn false, which is not correct since the daemon has been started by calling start().