Use multiauth package in management app #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! additional commit for fix here - #56 Didnt merge yet (but dev branch has same issue for me), because having same issues as here in management app - ceramicnetwork/js-ceramic#1311 Wondering if you have seen it as well, spent some time to trying to track it down in js-ceramic, regression since last release and will likely cause issues for any bundlers/transpilers, but havent been able to figure it out yet |
|
Yes I think I've seen this issue sometimes as well, thanks for pointing to the issue on js-ceramic, seems the cause could be the bundling config in 3id-did-provider so I'll start there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also imports types from the
didspackage