enhancement: Allow library user to provide some default GrpcChannelOptions. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. Could you please sign-off your commit as follows: |
markdBC
force-pushed
the
custom-grpc-channel-options
branch
from
460f190
to
db4b0be
Compare
|
@charithe Done! |
markdBC
force-pushed
the
custom-grpc-channel-options
branch
from
db4b0be
to
b6d98ce
Compare
|
@oguzhand95 No problem. I've made all your suggested changes. |
oguzhand95
approved these changes
Aug 4, 2023
markdBC
changed the title
markdBC
force-pushed
the
custom-grpc-channel-options
branch
from
b6d98ce
to
69b28c3
Compare
…tions. Signed-off-by: Mark Dinh <[email protected]>
markdBC
force-pushed
the
custom-grpc-channel-options
branch
from
69b28c3
to
6df1ebd
Compare
oguzhand95
approved these changes
Aug 4, 2023
|
Sorry about the repeated force pushes. Had some minor trouble with signature verification (not familiar with GitHub). All sorted. |
No problem 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add WithDefaultGrpcChannelOptions(GrpcChannelOptions) method to allow library user to configure GrpcChannel instance used by CerbosClient.
Fixes ##91